Awesome module!
By default the background color is black. I tweaked the module's CSS background to white and now my cropped images that don't conform to the minimum aspect ratio are nicely rendering in the desired colour scheme.

Perhaps a background colour configuration per style would be a great feature. Ideally I'd be working with quality images but some clients just throw any old rubbish at you sometimes.

Issue fork manualcrop-1975760

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

matthijs’s picture

matthijs
Primary language Dutch
commented
Project: Manual Crop (old) » Manual Crop
Version: 7.x-1.x-dev » 7.x-1.4
Priority: Normal » Minor

Hi,

I don't fully understand the requested feature, do you wish to change the overlay background colour per image style or the actual image background colour?

Matthijs

barwonhack’s picture

barwonhack commented

Hi, Thanks for looking at this request.
I am referring to .manualcrop-overlay-bg background color.

The image overlay style colour is used as the background colour of a cropped image if it is smaller than the target size. If this could be configurable it would assist when images are too small or their aspect ratio doesn't accommodate the desired corp proportions.

matthijs’s picture

matthijs
Primary language Dutch
commented
Status: Active » Postponed

The overlay colour isn't used as background for the cropped images, this is probably a coincidence with your current theme... It's a nice idea, but I'm postponing this for somewhere in the future.... (sorry)

yaelsho’s picture

yaelsho commented

Hello smilne23,
Can you give more details on how you succeed to change the background color from black?
I'm trying to change it to white with no success.
Thanks, Yael

fibigerg’s picture

fibigerg commented

I would love to know, where can i set/hack this, too. ImageCache Action Canvas module seems to not be working with manual crop :(

tarik.cipix’s picture

tarik.cipix commented
Issue summary: View changes

Would also love to know a way to change the default black color, ImageCache Action Canvas does NOT work in combination with Manual Crop.

barwonhack’s picture

barwonhack commented

you have to hack the code - its easy to find

martini9011’s picture

martini9011 commented

At #7. If you find a solution, it would be nice to share it with the rest.
Just saying it's easy to find is not the most helpful comment. Giving a filename, function name, or at least a clue as to where to look would be a lot more helpful.

I'm currently looking for a solution to this, and will try to create a patch once found.

woowlist’s picture

woowlist commented

Hi!
Does anybody can tell us where to change the background color?? Seems to be 'easy' but nobody tell us where...
smilne23 could you?
Thanks!

falco010’s picture

falco010
Location 🇳🇱 The Netherlands
commented

I also really need this option. This functionality has been postponed for 3 years, can you at least give us information on where this black background color is set so we can write a patch for it?

woowlist’s picture

woowlist commented

Hello, I solve this problem doing this.

Under admin/config/media/image-styles I edited an style with this effect: Define canvas 482x482 (center, center) #fff under image

So what I get it's a canvas of 482x482 of my cropped img positioned in the center with background in white under my image.

Hope you find useful.

See ya!

JayDarnell made their first commit to this issue’s fork.