Installing user permission feature when module not available crashes build

Dup of #1063204: Adding a new permission causes integrity constraint violation?

This seems like a much better solution than the other one. It's nice and clean and it presents useful feedback to the user.

Not postponing for now, but we might want to wait and see whether Core leaves responsibility on the caller's side or takes it over to callee's side, see: #737816: user_role_grant_permissions() throws PDOException when used with non-existent permissions (e.g. a permission for a disabled/uninstalled module)...

Would it be utterly horrid to set the module to 'features'? (either by creating a copy of user permission function that fills in 'features' instead, or via defining the missing perms in hook_permission somehow. Just occurred to me, not sure how dumb.

Module is so the perm can be uninstalled correctly, and since features is handling adding this permission, it doesn't seem so bad to set module to 'features'. Actually, if features set all the permissions it adds to features, that's one way to tell features added the mapping vs. something else. hm.

drupal_set_message(t('Module for permission !name not found.', array('!name' => $perm)), 'error');

This is not quite as informative as I would like. If we are doing a feature revert, this is fine, but if we are installing a profile with 500 modules, then this error doesn't tell much.
A better one would be:

drupal_set_message(t('Error in "!function". No module was found that defines permission "!permission". Cannot grant or revoke permission.', array('!function' => __FUNCTION__, '!permission' => $perm)), 'error');

I have no opinion whether this error message could be improved but
1) There's only one place/function using this error message tmk
2) I cannot think of anywhere else that adds in the function name like this.

Adding information that would not be apparent by looking at user_permission_features_rebuild could be useful, e.g. "defined by module !module" for example. or "during features rebuild of !module"

OK, so the !function part is not needed because you would just search in the code.

"defined by module !module" is a bit ambiguous, because there is the module which has the feature component, but each exported permission stores the module which defines the permission at the moment it was exported. But then it is not important what that module is, because all that is required is that at least one module (no matter which) defines that permission at the moment that the feature is being rebuilt. So, using your second suggestion, how about this:
Error in features rebuild of !module. No module defines permission "!permission".

Not too lengthy and gives some useful information.

Hello,

The patch in comment 1 breaks the profile installation under AEGIR environment, when the error is experienced.
I am adding a patch with lower error level -> warning.
Also added the discussed changes in the error message.
Changed the if() {....} else { .. } control flow to if ( ) { ... continue; } ... , seems better with less offsets.
The strange message generation is to keep the 80 characters row limit.

Best regards,
Nikolay Dobromirov

T needs to have text inside it for parsing to work correctly when making those translatable files

Changed the T function parameter to be a string literal.

Hm, instead of error, perhaps Issue?

I've seen with some jenkins tasks saying error will mark the build as failed ('warnings' are fine).

the user_permission_get_modules() function is still returning an array in the form " [edit terms in 10] => taxonomy" and so on revert all my features that define a permission are throwing this error

this was already reported here: https://drupal.org/node/1722524 so I'm closing again