Convert locale_custom_strings_* to settings

Can we add an example code to default.settings.php, please? If I'm not mistaken, we have done this for all new settings so far, and I think it really helps site builders / developers.

Forgot to say, that it looks great already!!! Found one other little nit-pick:

+++ b/core/includes/bootstrap.inc
@@ -1539,7 +1539,7 @@ function t($string, array $args = array(), array $options = array()) {
+    $custom_strings[$options['langcode']] = settings()->get('locale_custom_strings_' . $options['langcode'], array());

This should be \Drupal::settings()

Re #6: There is the following code in default.settings.php:

/**
 * String overrides:
 *
 * To override specific strings on your site with or without enabling the Locale
 * module, add an entry to this list. This functionality allows you to change
 * a small number of your site's default English language interface strings.
 *
 * Remove the leading hash signs to enable.
 */
# $conf['locale_custom_strings_en'][''] = array(
# 'forum' => 'Discussion board',
# '@count min' => '@count minutes',
# );

The example code should be changed to something like:

# $settings['locale_custom_strings_en'][''] = array(
# 'forum' => 'Discussion board',
# '@count min' => '@count minutes',
# );

Also:
1. I think, but I'm not sure, the [''] key is bogus.
2. We should move the entire block up to where the rest of the $settings are.
3. I think the docs could be improved, in particular they should mention that the _en part is in fact dynamic and works for any (enabled) language.

Looks very good to me, but I'm not into the locale system enough to RTBC this myself.

#17: drupal-locale_custom_strings_settings-1975490-17.patch queued for re-testing.

1. +++ b/core/modules/system/lib/Drupal/system/Tests/Common/FormatDateTest.php
   index 0a94658..2e4b7cf 100644
   --- a/core/modules/system/lib/Drupal/system/Tests/Menu/MenuRouterTest.php
   
   +++ b/core/modules/system/lib/Drupal/system/Tests/Menu/MenuRouterTest.php
   @@ -7,13 +7,12 @@
   +use Drupal\system\Tests\System\CustomStringsTestBase;
   ...
   -class MenuRouterTest extends WebTestBase {
   +class MenuRouterTest extends CustomStringsTestBase {
   
   +++ b/core/modules/system/lib/Drupal/system/Tests/System/CustomStringsTestBase.php
   @@ -0,0 +1,59 @@
   +abstract class CustomStringsTestBase extends WebTestBase {
   

   This baseclass really feel wrong. Can't we not just add this to the WebTestBase?

2. +++ b/core/modules/system/lib/Drupal/system/Tests/Menu/MenuRouterTest.php
   @@ -7,13 +7,12 @@
   -use PDO;
   

   A little be out of scope, but fine.

3. +++ b/core/modules/system/lib/Drupal/system/Tests/System/CustomStringsTestBase.php
   --- a/sites/default/default.settings.php
   +++ b/sites/default/default.settings.php
   
   +++ b/sites/default/default.settings.php
   +++ b/sites/default/default.settings.php
   @@ -463,6 +463,23 @@
   
   @@ -463,6 +463,23 @@
    # $settings['session_write_interval'] = 180;
    
    /**
   + * String overrides:
   + *
   + * To override specific strings on your site with or without enabling the Locale
   + * module, add an entry to this list. This functionality allows you to change
   + * a small number of your site's default English language interface strings.
   + *
   + * Remove the leading hash signs to enable.
   + *
   + * The "en" part of the variable name, is dynamic and can be any langcode of
   + * any enabled language. (eg locale_custom_strings_de for german).
   + */
   +# $settings['locale_custom_strings_en'][''] = array(
   +#   'forum'      => 'Discussion board',
   +#   '@count min' => '@count minutes',
   +# );
   +
   +/**
     * Base URL (optional).
     *
     * If Drupal is generating incorrect URLs on your site, which could
   @@ -589,20 +606,6 @@
   
   @@ -589,20 +606,6 @@
    # $conf['system.performance']['js']['gzip'] = FALSE;
    
    /**
   - * String overrides:
   - *
   - * To override specific strings on your site with or without enabling the Locale
   - * module, add an entry to this list. This functionality allows you to change
   - * a small number of your site's default English language interface strings.
   - *
   - * Remove the leading hash signs to enable.
   - */
   -# $conf['locale_custom_strings_en'][''] = array(
   -#   'forum'      => 'Discussion board',
   -#   '@count min' => '@count minutes',
   -# );
   -
   -/**
   

   Is there a reason why this was moved in the file?

.

+++ b/core/modules/simpletest/lib/Drupal/simpletest/WebTestBase.php
@@ -918,6 +925,41 @@ protected function writeSettings($settings) {
+   * Adds custom translations.

I think we should describe that the custom translations are added to the settings object.

Otherwise this looks really good.

Nice!

This looks great. Committed/pushed to 8.x, thanks!

Superb, thanks!

Added a quick change notice at https://drupal.org/node/2109883