Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
And this will be an interesting conversion
Comment | File | Size | Author |
---|---|---|---|
#34 | custom_strings_settings-1975490-34.patch | 10.52 KB | ParisLiakos |
#34 | interdiff.txt | 749 bytes | ParisLiakos |
#32 | custom_strings_settings-1975490-32.patch | 10.31 KB | ParisLiakos |
#32 | interdiff.txt | 1.3 KB | ParisLiakos |
#30 | interdiff.txt | 5.24 KB | ParisLiakos |
Comments
Comment #1
ParisLiakos CreditAttribution: ParisLiakos commentedThis could move to settings as well..not really sure
See also here #1813762-27: Introduce unified interfaces, use dependency injection for interface translation
Comment #2
ParisLiakos CreditAttribution: ParisLiakos commentedi will roll a patch for settings
Comment #3
ParisLiakos CreditAttribution: ParisLiakos commentedComment #4
tstoecklerCan we add an example code to default.settings.php, please? If I'm not mistaken, we have done this for all new settings so far, and I think it really helps site builders / developers.
Comment #5
tstoecklerForgot to say, that it looks great already!!! Found one other little nit-pick:
This should be \Drupal::settings()
Comment #6
ParisLiakos CreditAttribution: ParisLiakos commented#4: there is already one:)
#5: better wait for #1813762: Introduce unified interfaces, use dependency injection for interface translation, since it is rtbc and then inject settings to CustomStrings translator
Comment #7
tstoecklerRe #6: There is the following code in default.settings.php:
The example code should be changed to something like:
Also:
1. I think, but I'm not sure, the [''] key is bogus.
2. We should move the entire block up to where the rest of the $settings are.
3. I think the docs could be improved, in particular they should mention that the _en part is in fact dynamic and works for any (enabled) language.
Comment #8
ParisLiakos CreditAttribution: ParisLiakos commentedas per #6
Comment #9
ParisLiakos CreditAttribution: ParisLiakos commentedook, injected settings into CustomStrings object, move the settings part together with rest of them, and added documentation about the langcode part.
I agree that '' is bogus, but not sure what to do here
Comment #11
ParisLiakos CreditAttribution: ParisLiakos commentedmeh, the installer needs parameteters as well
Comment #12
ParisLiakos CreditAttribution: ParisLiakos commentedComment #14
ParisLiakos CreditAttribution: ParisLiakos commented#11: drupal-locale_custom_strings_settings-1975490-11.patch queued for re-testing.
Comment #16
ParisLiakos CreditAttribution: ParisLiakos commentedComment #17
ParisLiakos CreditAttribution: ParisLiakos commentedoh sigh, empty patch...interdiff is correct
Comment #19
ParisLiakos CreditAttribution: ParisLiakos commented#17: drupal-locale_custom_strings_settings-1975490-17.patch queued for re-testing.
Comment #20
tstoecklerLooks very good to me, but I'm not into the locale system enough to RTBC this myself.
Comment #21
aspilicious CreditAttribution: aspilicious commented#17: drupal-locale_custom_strings_settings-1975490-17.patch queued for re-testing.
Comment #23
ParisLiakos CreditAttribution: ParisLiakos commentedok lets reroll this one
Comment #25
ParisLiakos CreditAttribution: ParisLiakos commentedoh, forgot a line during reroll
Comment #26
dawehnerThis baseclass really feel wrong. Can't we not just add this to the WebTestBase?
A little be out of scope, but fine.
Is there a reason why this was moved in the file?
Comment #27
catchComment #28
dawehner.
Comment #29
ParisLiakos CreditAttribution: ParisLiakos commentedSo it is grouped with the rest of the settings section. also see #7
Comment #30
ParisLiakos CreditAttribution: ParisLiakos commentedmeh, the interdiff ;)
Comment #32
ParisLiakos CreditAttribution: ParisLiakos commentedComment #33
dawehnerI think we should describe that the custom translations are added to the settings object.
Otherwise this looks really good.
Comment #34
ParisLiakos CreditAttribution: ParisLiakos commentedprobably something like that
Comment #35
dawehnerNice!
Comment #36
Gábor HojtsyComment #37
catchThis looks great. Committed/pushed to 8.x, thanks!
Comment #38
Gábor HojtsySuperb, thanks!
Comment #39
Gábor HojtsyAdded a quick change notice at https://drupal.org/node/2109883