While profiling some interactions in a theme, I've noticed that the current 7.x-1.x releases do not support XHProf symbols with slashes in their name.

For example, if a theme has a templates directory and renders "templates/page.tpl.php" in a theme function, some of the symbols that are output will include run_init::templates/page.tpl.php. Due to the way that the xhprof_display_page menu callback works, the extra information is passed to the function, but not as a named argument.

CommentFileSizeAuthor
#1 xhprof-slashes-in-symbols-1975186-1.patch1.07 KBSteven Merrill

Comments

Steven Merrill’s picture

Steven Merrill commented
Status: Active » Needs review
StatusFileSize
new xhprof-slashes-in-symbols-1975186-1.patch1.07 KB

The following patch adds support for symbols with slashes, both in the callback itself and in links that are generated on the pages where slashed symbols are displayed.

  • Commit c916343 on 7.x-1.x by msonnabaum: 
    Issue #1975186 by Steven Merrill, msonnabaum: Symbol paths with slashes...
msonnabaum’s picture

msonnabaum commented
Issue summary: View changes
Status: Needs review » Fixed

I fixed this by just urlencoding the links. Simpler, and it seems to work fine.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.