Apologies for the issue barrage, I've just been raising them as I've come across them, but realistically they could all be in one "Fixes for non-node entities".

Anyway, the call to date_ical_get_location_fields() (which in turn eventually calls through to views_fetch_fields()) is missing the base table parameter (when called from date_ical_plugin_row_ical_entity::render()), so will always return node fields.

The render code responsible for the user-selectable date field correctly passes $this->base_table so doesn't suffer the same problem.

CommentFileSizeAuthor
#1 date_ical-language-check-1974798-1.patch1.15 KBstevetweeddale
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

stevetweeddale’s picture

stevetweeddale CreditAttribution: stevetweeddale commented
Status: Active » Needs review
FileSize
date_ical-language-check-1974798-1.patch1.15 KB

<edit>Apologies for the funkily named patch here… been an afternoon of bug fixing</edit>

coredumperror’s picture

coredumperror CreditAttribution: coredumperror commented
Status: Needs review » Fixed

Don't worry about the funky patch name. I do that kind of thing by accident all the time.

Thank you for all these great fixes! I feel dumb for claiming that Date iCal supports all entity types, without having actually tested that assertion.

Patch committed to dev.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

stevetweeddale’s picture

stevetweeddale CreditAttribution: stevetweeddale commented

Thanks for getting all of these committed!