At least the following strings cannot translated:

  • Change value
  • Change user roles
  • Change author
  • Stick (this string is tooo short to translate. I guess it should be Make sticky
  • Unstick (this string is tooo short to translate. I guess it should be Make unsticky
  • Promote to front page
  • Publish
  • Demote from front page

I do not known why this strings are missing in the $translatables array.

Comments

damiankloip’s picture

Status: Active » Closed (won't fix)

This module just provides default views, this would be exported from the vbo integration, and we are not in the game of manually adding translations to view exports.

hass’s picture

Status: Closed (won't fix) » Active

This does not fix the bug. The strings may need to be defined as translatable strings.

damiankloip’s picture

Status: Active » Closed (won't fix)

This is not an issue for admin views.

hass’s picture

Project: Administration Views » Views (for Drupal 7)
Version: 7.x-1.x-dev » 7.x-3.x-dev
Status: Closed (won't fix) » Active

Simply closing the case is not helpful.

merlinofchaos’s picture

None of those strings are in Views. Why is that here?

merlinofchaos’s picture

Project: Views (for Drupal 7) » Administration Views
Version: 7.x-3.x-dev » 7.x-1.x-dev

Views generally adds a list of translatable strings to all view exports, unless you actually turn that feature off. So maybe the views need to be re-exported with the strings. But that's not Views' job.

damiankloip’s picture

We are talking about bulk operation options only here, if anything this should be in vbo. It's not a views or admin views problem IMO.

hass’s picture

I think it's admin_views bug, but cannot look into it now. Wherever is the bug, itneed to be fixed.

damiankloip’s picture

How can this be solely an admin views bug? You will see this any time you use vbo.

dawehner’s picture

Project: Administration Views » Views Bulk Operations (VBO)
Version: 7.x-1.x-dev » 7.x-3.x-dev
Component: Code » Core

It's a bug in views bulk operations, that these strings, which are entered in the views UI, aren't marked as translatable through option_definition().

Once this is fixed properly in VBO, someone can rexport the views in admin_views and then you will have the strings on there.

infojunkie’s picture

If I understand the original report correctly, the operation names are untranslatable.

However, I was able to translate the operation names using the latest VBO 7.x-3.x-dev, including "Stick", like this:
* Enable locale.module
* Enable admin_views.module
* Enable an additional language and navigate to admin/content in that other language
=> The operation "Stick" appears in English
* Open a separate browser tab at admin/config/regional/translate/translate
* Filter the strings on "Stick"
* Translate the relevant string
* Refresh first tab
=> The operation "Stick" appears in the other language

Does this procedure fail for you? If so, where?

hass’s picture

The problem is that l.d.o don't see the strings if they are not inside the $translatables array where it need to be! So until the missing strings do not appear in the $translatables array of a view the bug is reproducible.

infojunkie’s picture

Thanks for the info. I committed a fix to VBO to add custom operation labels to the translatables.

What's needed now is to generate a patch for Administration Views, with the admin views containing the updated translatables.

hass’s picture

Project: Views Bulk Operations (VBO) » Administration Views
Version: 7.x-3.x-dev » 7.x-1.x-dev
Component: Core » Code

THX. Moving back.

dawehner’s picture

+          'value' => t($operation['label']),

I don't think we want to have the label translated in the actual export.

hass’s picture

Project: Administration Views » Views Bulk Operations (VBO)
Version: 7.x-1.x-dev » 7.x-3.x-dev
Component: Code » Core

Correct. Haven't been able to test how this patch works. Moving back.

infojunkie’s picture

@dawehner, that's how other translatables work. I checked by exporting a view while in another language: I got the localized strings on all translatables.

hass’s picture

It sound a bit like the bug I've reported in #1836000: Exporting view shows all translatable strings in UI language and not english, but the array need to look like this when exported in english UI, see http://drupalcode.org/project/admin_views.git/blob/refs/heads/7.x-1.x:/a... . All strings must be sourounded by t()

infojunkie’s picture

Yes, I am just being consistent with the rest of Views.

Although the fact that strings are surrounded by t() in the exported code is different from the fact that they are themselves localized during export.

infojunkie’s picture

@hass, any news from your testing? There's no point in keeping this issue open on the VBO side - I've done what needs to be done here.

hass’s picture

Had no time, but #15 sounds like a bug.

infojunkie’s picture

After spending an hour tracing through Views code, it appears that the option strings are *already translated* when they reach the translation export functions. I think the Views core translation export should be getting its strings from an untranslated source instead - this needs more work.

Since there's an open issue for that, I've removed the t() call from the operation labels. Committed the fix.

It would be great to move this issue to the next step.

infojunkie’s picture

Status: Active » Fixed

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.