entity_metadata_delete_file() currently doesn't check if the passed $fid is valid.

node_delete() for example, does this check (i.e. in node_delete_multiple() it iterates over the loaded nodes)

Patch will follow.

CommentFileSizeAuthor
#5 entity_1972668_5.patch1.69 KBmile23
#3 entity_1972668_3.patch1.7 KBmile23
#1 1972668-file-delete-1.patch566 bytesamitaibu

Comments

amitaibu’s picture

amitaibu
Primary language Hebrew
Location Israel
commented
Status: Active » Needs review
StatusFileSize
new 1972668-file-delete-1.patch566 bytes
amitaibu’s picture

amitaibu
Primary language Hebrew
Location Israel
commented
Title: Prevent WSOD if file doesn't load » Prevent WSOD if file doesn't load on file-delete

Better title

mile23’s picture

mile23
Primary language English
Location Seattle, WA
commented
StatusFileSize
new entity_1972668_3.patch1.7 KB

@Amitaibu: I made a regression test and reversed the logic for one less binary decision.

Status: Needs review » Needs work

The last submitted patch, entity_1972668_3.patch, failed testing.

mile23’s picture

mile23
Primary language English
Location Seattle, WA
commented
StatusFileSize
new entity_1972668_5.patch1.69 KB

Woops wrong test.

mile23’s picture

mile23
Primary language English
Location Seattle, WA
commented
Status: Needs work » Needs review
chris matthews’s picture

chris matthews commented
Assigned: amitaibu » Unassigned
Issue summary: View changes

The 6 year old patch in #5 to callbacks.inc applied cleanly to the latest entity 7.x-1.x-dev, but still needs review.