The following PHP Notices are thrown on all advanced help index pages when the core search module is not enabled:

Warning: Invalid argument supplied for foreach() in element_children() (line 6370 of /path/to/includes/common.inc).
Warning: Illegal string offset '#children' in drupal_render() (line 5837 of /path/to/includes/common.inc).
Warning: Illegal string offset '#children' in drupal_render() (line 5847 of /path/to/includes/common.inc).
Warning: Illegal string offset '#children' in drupal_render() (line 5885 of/path/to/includes/common.inc).
Warning: Illegal string offset '#printed' in drupal_render() (line 5892 of /path/to/includes/common.inc).

The fix is simple enough, patch to follow.

Comments

jamsilver’s picture

Assigned: jamsilver » Unassigned
Status: Needs work » Needs review
StatusFileSize
new527 bytes
kitikonti’s picture

Version: 7.x-1.0 » 7.x-1.x-dev
Issue summary: View changes
StatusFileSize
new669 bytes

Same error on fresh install with latest dev 7.x-1.x-dev

  1. Installed the standard profile
  2. Installed Advanced help Module
  3. Disabled Core Search Module
  4. Get errors on Advanced help pages

The patch dit not work on the latest stable and dev release (line numbers changed). I created a new patch for the latest dev.

gbirch’s picture

#2 works for me. Underlying problem is that advanced_help_index_page() must return a render array, or trigger warnings. At line 208 (of the current dev version) it returns a string if the advanced_help_search module is not enabled.

kaare’s picture

Status: Needs review » Reviewed & tested by the community

#2 did it for me. Simple bug, simple fix, good explanation. Ready to commit.

  • gisle committed e84de58 on 7.x-1.x authored by jamsilver
    Issue #1970608 by jamsilver, kitikonti: Patch to output READMEs as...

  • gisle committed e84de58 on 8.x-1.x authored by jamsilver
    Issue #1970608 by jamsilver, kitikonti: Patch to output READMEs as...
gisle’s picture

Status: Reviewed & tested by the community » Fixed
gisle’s picture

Version: 7.x-1.x-dev » 7.x-1.2

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.