We realized that sometimes callbacks from translators get lost.

This might happen due to some unavailability of your system during e.g. development / maintenance.
In order to make sure external jobs are not lost, we should somehow make sure all plugins implement a poll functionality.

We started with this at gengo.

I guess we should add this as a core feature and allow plugins to just specify their callbacks and core places the button.

CommentFileSizeAuthor
#8 tmgmt_1969434_note_2.patch567 bytesmiro_dietiker
#6 tmgmt_1969434_note.patch532 bytesmiro_dietiker

Comments

miro_dietiker’s picture

miro_dietiker
Location Switzerland
commented

By "specify their callbacks" i mean the plugin info hook.

miro_dietiker’s picture

miro_dietiker
Location Switzerland
commented

Related (Project TMGMT Gengo) #1969390: Re-add Poll button
Related (Project TMGMT OHT) #1899670: Add pull translation button

miro_dietiker’s picture

miro_dietiker
Location Switzerland
commented
Title: Poll translator button » Poll / Pull translator button
berdir’s picture

berdir
Primary language German
Location Switzerland
commented

Not convinced this is useful. Adding such a button is 5 lines of code and it could very likely be combined with additional form elements.

miro_dietiker’s picture

miro_dietiker
Location Switzerland
commented

I basically support this point.

However we need something like a documentation / checklist about what features a good plugin should provide.

miro_dietiker’s picture

miro_dietiker
Location Switzerland
commented
Status: Active » Needs review
StatusFileSize
new tmgmt_1969434_note.patch532 bytes

Attaching a patch that refers to the poll button concept.

berdir’s picture

berdir
Primary language German
Location Switzerland
commented 
+++ b/plugin/tmgmt.ui.interface.translator.incundefined
@@ -20,6 +20,8 @@ interface TMGMTTranslatorUIControllerInterface extends TMGMTPluginBaseInterface
+   * Every translator should place a Poll button here to sync the job state.

Only translators that have remote job states need to do this...

miro_dietiker’s picture

miro_dietiker
Location Switzerland
commented
StatusFileSize
new tmgmt_1969434_note_2.patch567 bytes

Retry!

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Needs review » Fixed

Fine ;)

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.