Add an option "Untranslated without suggestions" to the status filter on the translation page.

Attached a patch made by Jo Wouters a few weeks ago and a screenshot of the resulting status filter.

Comments

pvasili’s picture

It is an excellent patch

psicomante’s picture

Excellent! +1!

gábor hojtsy’s picture

Erm, why not make this more usable? If you look at the screen shot, you see two things set by the dropdown:

- has a translation (T+) or not (T-) or does not matter (Tn/a)
- has any suggestions (S+) or not (S-) or does not matter (Sn/a)

So we have two dimensions, each with three possible values.

All = Tn/a, Sn/a
Untranslated = T-, Sn/a
Has suggestion = Tn/a, S+
Translated = T+, Sn/a

Why add another arbitrary combination, when next time we come up with a need for another one? Why not separate the options then and make a usable selection for translation status and suggestion status independently. Let's come up with a good user interface for this, and if nobody else takes on the coding (although it would be great if you would :), I can do that.

pvasili’s picture

I think, that Sutharsan have offered very convenient variant

Jo Wouters’s picture

Assigned: Unassigned » Jo Wouters

I'll have a look at the interface.
Gábor is right that this might be solved in a better way.

gábor hojtsy’s picture

Actually three state checkboxes would fit here best. If we would have them. We have yes / no and don't care options, for which the three state checkboxes were born in the first place.

gábor hojtsy’s picture

Title: Filter option: untranslated without suggestions » Separate translation and suggestion status filters

Also suggested at http://drupal.org/node/196865 with a different approach before, which is not really applicable if we need these many dimensions to look up strings with.

Jo Wouters’s picture

Gábor, aren't you pointing to this issue ? #196865 = here :-)

gábor hojtsy’s picture

Well, I intended to point to http://drupal.org/node/185281

jose reyero’s picture

Status: Active » Needs review
StatusFileSize
new5.4 KB

Here's some patch. Creates a double drop down field like

Status [All/Translated/Untranslated][--/Has suggestion/No suggestion]

About the patch, it's quite small, splits the status filter in two form fields and uses some bitwise magic to keep the status as an integer, so links should work the same.

gábor hojtsy’s picture

Assigned: Jo Wouters » Unassigned

Wow, way to go, thanks for taking this on! Some notes:

- previous links to status 3 will not work or will be broken with this patch, right?
- there are some smaller code style issues with the elseifs
- I am not sure the status values as in the dropdown are too expressive; seeing "All" "---" does not tell me much. Maybe it would be better to have longer titles (see below).

I was again looking around the net for a tri-state checkbox implementation for jquery (at http://plugins.jquery.com/project/Plugins/category/20 for example, and also all around the net), but could not find one. It does not sound extremely hard to do, so I might take a look at implementing that sometime. With tri-state checkboxes (no, yes, don't care), these two options are easy to capture without the use of dropdowns. Anyway, since it would be a JS implementation, the dropdown will be kept anyway, so I'd like us to refine this patch a bit and commit soon :)

meba’s picture

StatusFileSize
new8.33 KB

OK, rerolling. Changed the stuff to radioboxes, polished a little bit.

What do you think now?

meba’s picture

StatusFileSize
new16.5 KB
new10.08 KB

This is an alternative patch for this and #220107: Allow search for user

It adds a new interface:

Only local images are allowed.

But it lacks a PHP implementation. If somebody would like to take care of it, please do so...

meba’s picture

StatusFileSize
new13.69 KB
new19.95 KB

OK, had a plenty of time in plane so I implemented a server-side stuff, polished a little bit.

Attaching a screenshot. Please note "Do not save this filter" checkbox, I will probably create another issue for this.

gábor hojtsy’s picture

I would be great to make the separated filters each a three state switch (AKA three state checkbox). I have been searching for such a ready-made plugin (yeah, it is surely done on the internet for countless times already). Just recently stumbled on this one: http://www.memorycraft.jp/project/jquery/j3ssw/index.html#tab2 not sure about the quality but helps you get the idea. Check the latest example, which has "yes", "no" and "don't care" items.

gábor hojtsy’s picture

Of course that three stat selector would not be a requirement at all, but would be a follow up.

pasqualle’s picture

Version: 5.x-1.x-dev » 6.x-1.x-dev

subscribe

pasqualle’s picture

Status: Needs review » Needs work

so this is called over-engineering
just reroll the patch in #10 because it is the perfect solution, and use the string "<Any>" when nothing is selected, because that is the string what views module use

reasons:
you can search for better string like "Any", "All", "Not selected", "Unspecified", "Choose", "---", "Don't care" or empty string, but none of them are good enough, so just keep the string change to another issue (or followup patch), because that will not be fixed any time soon..

I don't see any benefit with the filter on user who made the translation. Create a new issue for it, if you still think you need that.

use a simple filter, which means use dropdownlistbox or editbox controls. do not use radiobuttons that just take up too much space on the UI, and do not use 3 state checkbox, because it is not used in Drupal and it is a way much more complicated than a dropdown.

gábor hojtsy’s picture

Status: Needs work » Fixed
StatusFileSize
new6.46 KB

Here is a reroll of #10 which actually changes status values a bit more. Decided that those, who ran the server and had bookmarks will just update their bookmarks. Committed this to the module and rolled out to localize.drupal.org.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.