Strict warning: Declaration of views_handler_argument_draggableviews_book::query() should be compatible with views_handler_argument::query($group_by = false) in require_once() (line 6 of C:\UniServer\www\sites\all\modules\draggableviews\draggableviews_book\draggableviews_book_views_handler_argument.inc).

Seems draggableviews (especially draggableviews_book) is staying behind. Or is your dev version already compatible? If so, please close and sorry to bother you.

CommentFileSizeAuthor
#4 Book Weight re order Content.png30.75 KBseanenroute
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

iStryker’s picture

what PHP version are you using? Is it PHP 5.3 or PHP 5.4?

Mołot’s picture

iStryker’s picture

Title: Problem with current dev views » Strict warnings with PHP 5.4 and draggableviews_books
Version: 7.x-2.0 » 7.x-2.x-dev
seanenroute’s picture

Issue summary: View changes
FileSize
30.75 KB

Hi, I'm getting the same error with PHP4 and PHP5

Strict warning: Declaration of views_handler_argument_draggableviews_book::query() should be compatible with views_handler_argument::query($group_by = false) in require_once() (line 6 of C:\Users\SeanB\Sites\quiz75\sites\all\modules\draggableviews\draggableviews_book\draggableviews_book_views_handler_argument.inc).

It's a fresh install of 7.28, using the 7.2 dev of draggable views for Book.

csc4’s picture

Same problem here

Strict warning: Declaration of views_handler_argument_draggableviews_book::query() should be compatible with views_handler_argument::query($group_by = false) in _registry_check_code() (line 3168
includes\bootstrap.inc

Has anyone got a solution?

vmsiam’s picture

Same issue here!!! PHP 5.5
looking for a solution also.

Mołot’s picture

Manually adding

$group_by = false

to function definitoin seems to work around this, but it is quite "rude" approach, because variable is ignored.

  • iStryker committed 30f5d19 on 7.x-2.x
    Issue #1968588 by seanenroute, iStryker: Strict warnings with PHP 5.4...
iStryker’s picture

Status: Active » Fixed

@Molot is right. class views_handler_argument_draggableviews_book extends views_handler_argument. Views_handler_argument:query() probably didn't have $group_by = FALSE awhile back (maybe 7.x-2.x), but now it does.

Committed. I did not test it but I should not have to. Fix is trivial

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.