phone_libphonenumber() caches $detect_only; breaks unit tests

This patch fix it.

Sorry you have to add:

module_load_include('inc', 'phone', 'includes/phone.libphonenumber');

instead of

module_load_include('inc', 'phone', 'phone.libphonenumber');

Yes, put this in a unit test:

<?php
  function testSave() {
    $user = $this->drupalCreateUser();
    $user->phone[LANGUAGE_NONE][0]['number'] = '123456789';
    $user->phone[LANGUAGE_NONE][0]['countrycode'] = '33';
    user_save($user);

    $user = user_load($user->uid, TRUE);
    $this->assertEqual('123456789', $user->phone[LANGUAGE_NONE][0]['number'], 'Phone field number saved.', 'Phone');
    $this->assertEqual('33', $user->phone[LANGUAGE_NONE][0]['countrycode'], 'Phone field countrycode saved.', 'Phone');
  }
?>

Of course you might also create a field type phone called 'phone' on the 'user' entity.

And you are right because I get another problem which is: can't load libphonenumber/PhoneNumberUtil.

Are you reproducing the code via the Drupal UI ? Because with the drupal UI and user form editing it works.

Reproduce the step using the user_save() function. I gave you a sample of a Unit Test function, do you want a full class to execute ?

Yes I use the -dev version.

It is not loading the library because:

In a testing context, the module is installed and then executed in the same thread.

The function phone_libphonenumber() caches a boolean value called $success which remains true once checkings are done at module installation (e.g. with libraries_detect() function).

Thus, when calling again the phone_libphonenumber() function in the phone_field_presave function on user_save(), $success is already set to TRUE and the loading of php files never happen.

To resolve the problem I had to write these lines of code in save() method of the user controller:

<?php
    module_load_include('inc', 'phone', 'includes/phone.libphonenumber');
    libraries_load('libphonenumber-for-php');
?>

This work-around fixed my test case.

To reproduce the steps, I guess you just call phone_libphonenumber(TRUE) once somewhere in your code, then calling phone_libphonenumber() wont load the library.

This is easily fixable by changing the way this function works, and cache another static variable which indicates whether or not the library has been loaded.

It not only break unit test, but possibly a client request which first checks if the library exists (with detect) before loading it.

The patch in #10 is working for me.