Files: 
CommentFileSizeAuthor
#14 interdiff.txt3.59 KBAlbert Volkman
#14 twitter_cards-1963678-14.patch7.6 KBAlbert Volkman
PASSED: [[SimpleTest]]: [MySQL] 73 pass(es).
[ View ]
#13 twitter_cards-1963678-8.patch7.65 KBgnuget
PASSED: [[SimpleTest]]: [MySQL] 73 pass(es).
[ View ]
#12 interdiff.txt2.43 KBgnuget
#12 summary_large_image_and_gallery_cards_additions-1963678-7.patch2.28 KBgnuget
#6 summary_large_image_and_gallery_cards_additions-1963678-6.patch2.43 KBDC_Marc
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch summary_large_image_and_gallery_cards_additions-1963678-6.patch. Unable to apply patch. See the log in the details link for more information.
[ View ]

Comments

DamienMcKenna’s picture

Component:Code» Other tags
archimedes’s picture

Seconded.

One question/suggestion:
My suggestion is to make the field for the type of card into a regular open field entry. I wasn't clear on why that field is a dropdown select box. It didn't look like my selection in that box affected any of the other fields, but it adds the extra overhead of requiring a module update whenever Twitter adds a new card design (even ones that use existing other tags/fields). Am I missing something?

troybthompson’s picture

summary_large_image as well. I don't see the need for the select either, unless it changes which tags get outputted or something.

Chris Charlton’s picture

+1 for 'summary_large_image' type.

Chris Charlton’s picture

FYI, Twitter controls 'twitter:domain':

RESTRICTED - twitter:domain will be automatically generated from your card's URL.

This is mentioned in the Twitter Card Validator tool.

DC_Marc’s picture

Version:7.x-1.x-dev» 7.x-1.0-beta7
Status:Active» Needs review
StatusFileSize
new2.43 KB
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch summary_large_image_and_gallery_cards_additions-1963678-6.patch. Unable to apply patch. See the log in the details link for more information.
[ View ]

Let me know if this patch works. I had a business case for adding summary_large_image and gallery, so that's all this does. I tested my site using the Twitter validator, and it seems to work.

Status:Needs review» Needs work

The last submitted patch, summary_large_image_and_gallery_cards_additions-1963678-6.patch, failed testing.

DC_Marc’s picture

This patch wasn't tested on the latest code base, which is why it failed the automated test, but it should work against 7.x-1.0-beta7. Anyone have that installed and can verify? I wanted to test on a clean working stable version.
Marc

JordanMagnuson’s picture

Issue summary:View changes
Status:Needs work» Reviewed & tested by the community

Working for me on production site. Would love to see this committed.

gnuget’s picture

This patch doesn't add support for:

- app-card
- product-card

Only for:

- Gallery card
- summary_large_image

And needs to be re-rolled for the development version.

gnuget’s picture

Version:7.x-1.0-beta7» 7.x-1.x-dev
Assigned:Unassigned» gnuget
Status:Reviewed & tested by the community» Needs work
gnuget’s picture

Well after to look in the patch the problem was the file wasn't made in the metatag module but in the Drupal root directory.

This new version should be pass the tests.

I will be working on this.

gnuget’s picture

Assigned:gnuget» Unassigned
Status:Needs work» Needs review
StatusFileSize
new7.65 KB
PASSED: [[SimpleTest]]: [MySQL] 73 pass(es).
[ View ]

Here another patch which include the "App" card and the "Product" card.

Albert Volkman’s picture

StatusFileSize
new7.6 KB
PASSED: [[SimpleTest]]: [MySQL] 73 pass(es).
[ View ]
new3.59 KB

This patch re-rolls the previous patch, and fixes the "Iphone" and "Ipad" typos.

DamienMcKenna’s picture

Status:Needs review» Fixed

Committed. Thank you for the help!

Albert Volkman’s picture

Issue summary:View changes

Status:Fixed» Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.