Integrate Commerce TNT with Physical Fields module.

I can see your module provides "Number of Packages", while the Lenght, Width and Weight say they are total sizes (of all packages of that product).
The Physical Fields IMHO does not have the concept of "Number of Packages".
I suspect - based on your code - that TNT cares about how many packages you want to ship, but wants total sizes.
Am I right here? If so, did you have an idea of how to overcome this "Number of Packages" with the Physical Fields module?

Thanks,
Marji

I'm attaching a patch which uses the Physical Fields for the dimensions and weight.
I'm making the assumption there is only one package for each product, the same way the Commerce Australia Post module does it.

I have not provided an update_hook as this is a potentially tricky thing as it would require each product bundle that has at least one product with TNT shipping activated to have the physical fields attached.
If the fields were already there, I'd have to decide whether to update the physical fileds values with the values from the commerce_tnt table on not (for example, a user can have both Commerce TNT and the Commerce Australia Post module enabled and have the dimension / weight info stored twice - are they exacly the same?).
That means, I'm not dropping the commerce_tnt table, thought it is not used anymore.

I'm happy to put together the update_hook if desired. In yes, please elaborate on the best approach of doing so. Thanks!

Hi John, Martin and I work for the same company. We were using Martin's patch for a while but have now moved back to your way of storing shipping data since the release of alpha4. If you wish to close this ticket you can do so without fear of us being offended. There is probably no one using this code in the wild now, although we did use it fine for a year or so.

Hi John,
first of all, I work with Martin and Murray. :-) We went back to using this patch again. I reported few more issues while using clean alpha3 and alpha4. Most of them are solved by using this patch.

Hi John, after taking a look at the new alpha4 we ended up going back to the Physical Fields approach contained in the above patch.

There remains a pretty bad bug in commerce_tnt.xml.inc (line 31) where orders with multiple products will have all but the last product ignored. The info needed to be added to an array, not a plain variable, ie add the data to an array item using, $shipping_info[]... We should have raised a bug with this one, however, I believe that it was fixed with the above patch.

Using the Physical code with save around 330 lines of code and make it much simpler.

So we have gone back to our old way with this patch. In the light of this, we would still be interested in a refactored version somewhere down the line.