In testing some RTL stylesheets I noticed the overlay border radius CSS needed work.

Screenshot before

chrome.png

After patch
Chrome

chrome-after.png

FF and Safari after shots also attached. Have not yet tested in IE.

CommentFileSizeAuthor
#5 overlay-rtl-1961924-5.patch767 bytespameeela
overlay-rtl.patch767 bytespameeela
safari-after.png13.92 KBpameeela
ff-after.png14.32 KBpameeela
chrome-after.png7.22 KBpameeela
chrome.png25.84 KBpameeela

Comments

pameeela’s picture

pameeela commented
Issue tags: +RTL, +overlay

Added tags

Status: Needs review » Needs work

The last submitted patch, overlay-rtl.patch, failed testing.

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
commented
Issue tags: +Novice
pameeela’s picture

pameeela commented

Dunno why this failed, possibly because I hadn't updated in a while. I can give it another go on Monday.

Is this relevant anymore though in light of the new Seven style guide? http://groups.drupal.org/node/283223 I couldn't seem to find any kind of timeline for the actual implementation of that in Drupal 8.

pameeela’s picture

pameeela commented
Status: Needs work » Needs review
StatusFileSize
new overlay-rtl-1961924-5.patch767 bytes

Trying again....

pameeela’s picture

pameeela commented
Status: Needs review » Closed (duplicate)

Oops! Someone already fixed this, it's been committed.

jessebeach’s picture

jessebeach commented

That might have been me who fixed it, but thank you for the patch pameeela! IF you want to work on Overlay styling further, check out http://groups.drupal.org/node/283223#Overlay and contact ry5n.