We have a subscription, but we test on our local machines which are not connected. Having the message at the top is a real bummer for theming the pages. So I suggest adding a variable that will hide the subscription messages. Patch coming.

CommentFileSizeAuthor
#10 1960452-d7-10.patch1.23 KBcoltrane
#9 1960452-d7-3.patch826 bytesredndahead
#2 1960452-d7-2.patch1.63 KBredndahead
#1 1960452-d7-1.patch1.34 KBredndahead

Comments

redndahead’s picture

redndahead commented
Status: Active » Needs review
StatusFileSize
new 1960452-d7-1.patch1.34 KB

Here you go

redndahead’s picture

redndahead commented
StatusFileSize
new 1960452-d7-2.patch1.63 KB

Sorry didn't test.

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented
Status: Needs review » Reviewed & tested by the community

Unless you'd like an admin screen to disable this ad, I think a variable is enough.

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 1960452-d7-2.patch, failed testing.

coltrane’s picture

coltrane
he/him
commented

Would you set this via your local test environment's settings.php? Do you have the ability to build in automatic disabling of the Connector module into your workflow for your test sites?

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented

It could be in $conf, but in this case we'd have it in strongarm. And this isn't disabling functionality, just the annoying message (for test sites).

redndahead’s picture

redndahead commented

And in all honesty that message is an advertisement. The fact that I can't turn off an ad for a service that I already have unless I change my build is kind of off-putting.

redndahead’s picture

redndahead commented
Status: Needs work » Needs review

#2: 1960452-d7-2.patch queued for re-testing.

redndahead’s picture

redndahead commented
StatusFileSize
new 1960452-d7-3.patch826 bytes

Whoops that was more of an interdiff. Here is a new one.

coltrane’s picture

coltrane
he/him
commented
StatusFileSize
new 1960452-d7-10.patch1.23 KB

Updated with _uninstall() line to delete this new variable.

coltrane’s picture

coltrane
he/him
commented
Status: Needs review » Fixed

Committed. Thanks! http://drupalcode.org/project/acquia_connector.git/commit/5134169

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.