Node create/edit sitemap Default priority displays as 0.0 when node type priority has not been implicitly set.

It appears that array keys must be strings or whole numbers. Fixed in CVS commit 90792.

I found this behavior happening in a site upgrading from the latest to the 1.1 version. After upgrading, I saw the 0.0 showed in the description field.

I went down to the code and thought there might be something happening in terms of int/string keyed arrays such as explained in this issue for D5 but after some testings I wasn't able to replicate the problem. I am sure that somehow a decimal got into the db:

select * from variable where name like '%xmlsitemap_node_type_priority_%';

+---------------------------------------+--------+
| name                                  | value  |
+---------------------------------------+--------+
| xmlsitemap_node_type_priority_product | d:0.5; |
+---------------------------------------+--------+

But how or why I am not sure, as I wasn't able to do it again with the new version. Maybe this was left by some previous version.

Anyway, I just noticed that constants as integer or strings are mixed up along the code for the same thing, so it may be worth to look at this and think if it's worth standardizing it to one or the other.

For ie:

xmlsitemap_node.module:116

    $default = variable_get('xmlsitemap_node_type_priority_'. $node->type, '0.5');

xmlsitemap_node.module:145

      '#default_value' => variable_get('xmlsitemap_node_type_priority_'. $form['#node_type']->type, 0.5),

For my own modules, I generally define a constant on top of the module for this, to avoid missing a variable_get() if I somehow change the default value, so something like:

define('XMLSITEMAP_NODE_DEFAULT_NODE_TYPE_PRIORITY', '0.5');

and a

variable_get('xmlsitemap_node_type_priority_' . $NODETYPE, XMLSITEMAP_NODE_DEFAULT_NODE_TYPE_PRIORITY);

globally along the code might be a good idea.

Just leaving here for a thought, as again, I wasn't able to put back that decimal value in the db.