I'm not sure why its not working, but it doesn't seem to be. On a potentially related issue, I'm getting:

array_merge_recursive(): recursion detected in [dir]/includes/common.inc on line 1674 with devel on. It has to do with the fact that the following code is being called twice.

if ($settings['filling_tabs'] > 0) {
    drupal_add_js(drupal_get_path('module', 'panels_tabs') .'/panels_tabs.js');
        drupal_add_js(
          array(
            'panels_tabs' => array('filling_tabs' => array( $id => $settings['filling_tabs']))
          ), 'setting');
  }

Comments

najibx’s picture

I don't find this error with panels 5.x-2.0-alpha14 Last updated: November 22, 2007 - 06:55 and panels_tabs-5.x-1.2 2007-Nov-15. ( not the panels_tabs-5.x-1.x-dev)

How do you find this error with devel on, anyway? On the Recent log entries? I don't see any errors.

I just could not see the "panels_tabs" option, only sees regular "Provide Menu as Tab" which is nothing related to this module is, isn't?

So which latest panels module is working ? It does says..... Dependencies Panels 2 alpha 11 or better ...

wim leers’s picture

Category: bug » support
Priority: Critical » Normal

I can't reproduce that either.

najibx: look in the "Layout" tab, there you can choose the style.

wim leers’s picture

Title: Incompatable with alpha-14 of Panels2 » Incompatible with Panels 2 alpha 14
wim leers’s picture

Status: Active » Postponed (maintainer needs more info)
wim leers’s picture

Status: Postponed (maintainer needs more info) » Closed (fixed)

Assuming this doesn't need fixing, since the lack of replies.

geshan’s picture

It needs fixing. See another issue here:
http://drupal.org/node/199786

SolomonGifford’s picture

Sorry, I thought I had subscribed to this issue and hadn't seen any responses in my email...

I have gone a different route, so I'm not using the panels_tabs anymore. I'll post an update if I attempt again.

michelle’s picture

Just for confirmation, the tabs work fine with panels beta 1.

Michelle

wim leers’s picture

Status: Closed (fixed) » Fixed

Yep, also works fine here in beta 1. The version for Panels 2 beta 1 -- version 1.3 -- also has several other improvements. So please upgrade to those versions.

najibx’s picture

OK. got it running.

I was wondering the best practices to modify the tabs style.
I change the tabs.css located in the modules/jstools/tabs

how can I have multiple tabs style and put the tabs.css in theme folder. must override in template.php?

tq

wim leers’s picture

Assigned: Unassigned » wim leers

Please start a new issue for a new question next time!

You should not change tabs.css. You should override the styles based on the IDs that Panels provides (or the ones that you enter, because you can enter a CSS id for any Panel), which allows you to target each Panel specifically.

stevryn’s picture

i just installed Panels 2 beta 1. I am still seeing this error when trying to view my panel page:

warning: array_merge_recursive() [function.array-merge-recursive]: recursion detected in /home/ndpweb/xampp/htdocs/drupal_main/includes/common.inc on line 1667.

stevryn’s picture

Wait...could this be because you have content laid out in a 2 column panel?? When I deleted my content and placed it in a SINGLE column it doesnt appear to have that error anymore.

wim leers’s picture

Component: Code » Documentation
Priority: Normal » Critical
Status: Fixed » Active

Hm. It doesn't make sense to put it in a 2-column lay-out, because Tabs panel style works on each pane of *one* panel. But I guess that needs much better documentation... Marking this issue as such. Will do this as soon as I have the time.

najibx’s picture

Wim Leers,

Sorry about that. Will not do that again :P
Thank you for the tips. I overlook that.

wim leers’s picture

Title: Incompatible with Panels 2 alpha 14 » Document that a single column layout should be used
wim leers’s picture

Component: Documentation » Code
Category: support » bug
Status: Active » Closed (duplicate)

No longer necessary, fixed: http://drupal.org/node/207486.