Using the default Commons Group Browsing Widget in a pane on the groups homepage, I'm seeing plain text rather than rendered buttons from HTML (see image).

It appears as though commons_bw_generate_group_widget() builds the $tabs array with several 's which are displayed as plain text. The $tabs arrays are sent as an argument in quicktabs_build_quicktabs inside the commons_bw.module file.

Looking at that function in the quicktabs module itself, there is a checkplain() which might be causing the issue.

However, that code was written in 2011, and it looks like the theming on this widget was completed just a few weeks ago. #1710782: Theme the Group Homepage browsing widget

Is anybody else experiencing this problem?

CommentFileSizeAuthor
commons_gw_html_unrendered.png47.54 KBsheldonkreger

Comments

sheldonkreger’s picture

Please disregard the link to the checkplain() code in quicktabs, wrong link.

Here's the right code:

http://drupalcode.org/project/quicktabs.git/blob/52c4bd9cd3862a4ee754e7c...

jpontani’s picture

This should be resolved from #1941824: Content tabs on the group landing page are being escaped, and should be part of the latest release.

sheldonkreger’s picture

Status: Active » Fixed

Updating to 3.1 fixes! Thanks :-)

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

RobKoberg’s picture

Status: Closed (fixed) » Needs work

The latest version of quicktabs brings this bug back. The settings appear to be correct in that html => TRUE, but the spans are escaped.

ezra-g’s picture

Version: 7.x-3.0 »
Issue tags: +Commons 7.x-3.3 radar

Tagging for 3.3 radar - We may not be running an affected version of QuickTabs.

moheshmohan’s picture

ohh this is exactly my problem @jpontani

i have posted the issue in https://drupal.org/node/2006718

So is there some kind of fix for this... this is really annoying

moheshmohan’s picture

I found that the issue is not coming from the line mentioned in comment #1 it seems to be coming from here actually

http://drupalcode.org/project/quicktabs.git/blob/52c4bd9cd3862a4ee754e7c4c8e3489588332763:/plugins/QuickQuicktabs.inc#l69

This build_links function is called in my case, but still can not figure out where does the span gets escaped :'(

RobKoberg’s picture

The quicktabs version shipping with Commons works correctly, so you could use that one.

moheshmohan’s picture

i changed to that one and yes that works .... thanks mate :)

devin carlson’s picture

Status: Needs work » Fixed

I haven't been able to duplicate this issue using the latest -dev release of Commons. As of #1983722: April 2013 module update meta issue, Commons is checking out the latest commit to Quicktabs which doesn't appear to be affected.

Since it sounds like this issue is present in older releases of Quicktabs, I'd suggest using the latest -dev release of Quicktabs or upgrading to the latest -dev release of Commons (which includes this version of Quicktabs) until Commons 3.3 is released.

Please feel free to reopen this issue if you're still having this problem with the latest Commons -dev.

RobKoberg’s picture

$ drush up quicktabs
brought down the released version, even though I am working off of commons git dev branch. (well kind of, not exactly sure the best practice for updating)

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

monkeyangst’s picture

Version: » 7.x-3.2

I am seeing this issue on Drupal Commons-7.x-3.2-core even with quicktabs-7.x-3.4-dev... wondering what versions you all are using that you're not seeing this. It's driving me nuts.

vooveek’s picture

Status: Closed (fixed) » Active

Have the same problem, I've "fixed" it removing 'span' attribute in line #92. Anyway some support would be appreciated.

vooveek’s picture

Have the same problem, I've "fixed" it removing 'span' attribute in line #92. Anyway some support would be appreciated.

ezra-g’s picture

Status: Active » Postponed (maintainer needs more info)

I'm unable to reproduce on a fresh install of Commons 3.x packaged with build-common-dev.make. Note that Commons is using QuickTabs module with hash version 89f7fd0b7313782d0f7504996daa36bde798ec79 .

Can someone post steps to reproduce on a fresh install packaged with build-common-dev.make?

TravisJohnston’s picture

I just performed an update 2 days ago to my entire code base, including 7.x-3.2 Commons. Using the default quicktabs in the profile, I noticed my tabs broke again. So I installed the newest dev version of Quicktabs but still theres an issue.

Originally the problem seemed to be in that Commons was restricting me from ever creating my own quicktabs... because you have no option to alter or create quicktabs with the profile module, so if you installed the module separately and had access to create your own, it would break.

So I removed the additional module before and dealt with not being able to customize Commons, but not the recent update broke it again.

xandermar’s picture

Has anyone found a fix?

TravisJohnston’s picture

None yet..

I have tried removing quicktabs from my module/contrib folder and clearing cache, etc. to make it default back to the commons one but nothing. Also tried installing and testing Quicktabs with different versions, all the way back to 3.1.

What I confused about though is that I do not see any of the code listed in the initial comments. Also I ran a scan on the word "span" to see if I could find the hardcoded quicktabs in the commons profile and couldn't find them either.

xandermar’s picture

The hard code for the "span" tag is in:
./profiles/commons/modules/contrib/commons_bw/commons_bw.module

line 92

TravisJohnston’s picture

Found it, thanks @xandermar. I just removed the spans, so it at least looks OK for now.

xandermar’s picture

Weird - seems somewhere down the line the code is being urlencoded but I haven't been able to find where....

devin carlson’s picture

Version: 7.x-3.2 » 7.x-3.x-dev
Status: Postponed (maintainer needs more info) » Fixed

As ezra-g mentioned in #17 this is fixed in Commons 3.x (packaged with build-common-dev.make).

You need to use the latest git checkout/-dev release of Commons Browsing Widget and a git checkout of revision 89f7fd0 or the latest -dev release of Quick Tabs.

xandermar’s picture

@Devon - already tried ezra-g's suggestion in #17 - didn't work for me.

Also followed your suggestion:

You need to use the latest git checkout/-dev release of Commons Browsing Widget and a git checkout of revision 89f7fd0 or the latest -dev release of Quick Tabs.

That didn't work either.

Here's my environment:

  • Commons: 7.x-3.2
  • Drupal: 7.22
  • Quick Tabs 7.x-3.4
  • Commons Browsing Widget 7.x-3.0
TravisJohnston’s picture

I switched over to the newest dev version of QuickTabs, placed in my all/modules/contrib folder, and it seemed to finally work. I didn't have to get a particular commit.

xandermar’s picture

Great work TravisJohnston!

That fixed it for me as well - thank you!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

albie001’s picture

Thanks, latest dev version has indeed fixed the problem.