Hello,
I use D7 with webform 7.x-3.18 and webform2pdf 7.x-3.x-dev
I've this problem. When I try to download multiple PDF submissions I obtain pdf document with the same number of submissions, but every page has same data.

I've found in webform this line:

function _webform_filter_values($string, $node = NULL, $submission = NULL, $email = NULL, $strict = TRUE, $allow_anonymous = FALSE) {
global $user;
static $replacements;
....

If I remove "static" it work fine.

Please review

CommentFileSizeAuthor
#2 issue-1956336-2-webform-bad-_webform_filter_values-static-cache.patch678 bytesmr.york
#1 issue-1956336-1-webform2pdf-hotfix-bad-_webform_filter_values-static-cache.patch583 bytesmr.york

Comments

mr.york’s picture

mr.york commented
Status: Needs review » Needs work
StatusFileSize
new issue-1956336-1-webform2pdf-hotfix-bad-_webform_filter_values-static-cache.patch583 bytes

Works for latest webform-3.x dev.

mr.york’s picture

mr.york commented
Project: Webform2PDF » Webform
StatusFileSize
new issue-1956336-2-webform-bad-_webform_filter_values-static-cache.patch678 bytes

Fixed _webform_filter_values() function static cache problem.

quicksketch’s picture

quicksketch
he/him
commented
Title: Download multi-submissions: same data on every page » Same data on every page when using Webform2PDF to download multiple submissions
Status: Needs work » Fixed

The Webform 4.x version doesn't seem to be affected by this problem, since it uses the normal D7 token system.

To solve this problem on the Webform2PDF side, you could use drupal_static_reset('_webform_filter_values'); in between printing each submission out.

That said, I don't think this is a bad solution and it looks like it would be acceptable for the 3.x branch, so I've committed this patch to both 3.x versions.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.