When selecting as views filter and nothing is selected the top selection should be named -Any- instead of -None- (the opposite as in node creation page)

p.s. You got my praise one more time for this module, awesome work

Comments

trevorkjorlien’s picture

trevorkjorlien commented

I know this isn't the best solution, as it's better to do it in an override, but what I've done to achieve this is edit the "shs.js" file, found in the 'shs/js' folder.

In version 7.x-1.6, it's on line 139. Change '- None -' to '- All -'. Flush the cache, and it will be changed everywhere SHS is used.

Again, better to do this in an override, as when you update the module, this change will be reverted.

Mike Dodd’s picture

Mike Dodd commented

this module is fantastic, but I also found this problem it makes much more sense as - All - and so should be changed. I know you have wrapped it inside Drupal.t but string overides has currently got some problems doing javascirpt translations and so I have to to mod this file :(

When noting is selected it will return all results and so should really be update to "- All -"

options[options.length] = new Option(Drupal.t('- All -'), 0);

cheers

stborchert’s picture

stborchert
he/him
Primary language German
commented
Status: Active » Fixed

Committed a tiny change to Simple hierarchical select so it uses the same setting as Views (configurable on admin/structure/views/settings).

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.