More Seven Theme issues: #1986434: New visual style for Seven
Motivation
The Seven style guide is heavily being implemented in a sandbox at https://drupal.org/sandbox/ry5n/1932040. Members of the Spark team wanted to attempt to marry the proposed Overlay style from the UX team with forms changes proposed, so looking at implementing the overlay style as proposed in the style guide is needed.
Proposal
Although a sandbox issue for implementing (outside of core) prototype for overlay exists at #1945556: Add Overlay and Modal components, to attempt to marry the overlay with #1880168: Introduce top-level sections for all forms we need to build a core implementation. It can be taken and cleaned up later on and either included with the sandbox or used as one of many stepping points for the style guide to get into core.
The proposed design looks like the following:
Related Issues
Comment | File | Size | Author |
---|---|---|---|
#93 | Screen Shot 2013-10-28 at 18.50.13.png | 231.64 KB | LewisNyman |
#93 | Screen Shot 2013-10-28 at 18.53.21.png | 232.29 KB | LewisNyman |
#93 | Screen Shot 2013-10-28 at 18.50.30.png | 275.67 KB | LewisNyman |
#93 | Screen Shot 2013-10-28 at 18.53.08.png | 264.31 KB | LewisNyman |
#91 | overlay-restyle-1953374-91.patch | 11.03 KB | LewisNyman |
Comments
Comment #1
Gábor HojtsyDemonstration image.
Comment #1.0
Gábor HojtsyAdd overlay image
Comment #2
Gábor HojtsyTada! First version:
Some notes:
- Font types and sizes from the style guide are obviously *not* applied
- Applied the style guide provided hsla(0, 0%, 42%, 0.65) for title bar background
- No radius value specified, so took 5px for edges of overlay and tabs bar
- No padding value specified, so took 15px 25px
- Attempted to align paddings for different things (eg. close button is 25px positioned inside the title bar too)
- Used "burlap" color for tabs background, assuming that is right
Missing/incorrect:
- Do not have X for close button and star image for shortcuts, so kept them as-is
- Second level tabs are still displayed as part of the page, not at top
- Tabs not yet aligned with content indentation
- Dropped bottom padding, but we surely need some(?)
- It certainly does not follow the latest and greatest CSS code style... eg. I modified the tabs CSS that I took from http://drupal.org/node/1945542 to apply the right selectors for current tabs markup instead of attempting to align Drupal's menu rendering outright :)
- Let me know everything else :D
Comment #3
Gábor HojtsyFixed color of tab background. Used the color that used to be the border bottom. With the border lost, I could position the tabs more easily, so they are not 1px out of line now. Also fixed the indentation so the contents are 15px indented like the tabs vs. 25px before. So tabs line up with content. The design has some fancy backgrops for tabs that the implementation in #1945542: Add Navigation Tabs did not have, so this does not have that either.
Comment #4
jessebeach CreditAttribution: jessebeach commentedThere's some responsiveness and breakpoint integration we can port from #1829326: Convert Overlay to leverage core breakpoints and media queries to determine its presence and styling.
Comment #5
jessebeach CreditAttribution: jessebeach commentedAs much as possible let's use ems for these types of placement and padding values.
We'll need to pull base styles apart from theme styles.
Let's get rid of these superfluous wrapper divs.
Set a solid background color for browsers that can't do hsla()
Is this temporary? Seems to be an end run around cache
Comment #6
ry5n CreditAttribution: ry5n commentedThis is starting to shape up already. I do feel like we’re still validating the design (over in the sandbox), so I worry a little about getting into implementation details too early. On the other hand, it might be a good way to see how things integrate? On the whole, I’m happy to see this and happy to help.
One other thing: the style guide intentionally omits breadcrumbs! For some reason we neglected to highlight that fact in the proposal… and possibly no-one noticed?
Comment #7
Gábor Hojtsy@jesse: the use of px stems from the tabs styles from #1945542: Add Navigation Tabs as well as the fact that the title header, the tabs and the page body use varying font sizes, so using the same or similar em sizes would not line up their first letters. Which makes me notice I did not update the positioning of the close button when I updated stuff to use 15px spacing. The 46px left position with a 26px wide close button comes down the 20px padding that was used prior. That needs to be fixed.
@ry5n: yay for removing breadcrumb :) will do.
Comment #8
Gábor HojtsyUpdates:
- implemented secondary tabs on the overlay instead of in the page
- fixed positioning of the close button (note that it is 26px wide but the actual visual X is in the middle, so the positioning math does not end up, but the right edge of the circle is at the 15px spacing position from the border) - this will need to change when the actual proposed X comes anyway
- removed breadcrumb and added a 15px top-bottom padding instead to #page (otherwise the page content was running all the way against the tabs/header given that no #branding is displayed now)
I did not address Jesse's feedback yet (did not integrate tabs for ease of interdiffing (and also since it is supposed to be used for the same tabs in the admin area.
I also contacted Bojhan for images for the X and the stars for shortcuts.
Overlay with no tabs:
Overlay with one level of tabs:
Overlay with two levels of tabs:
Comment #9
Gábor HojtsyGot a close image and star images from Bojhan. The close image was black so I made it white, the star images were individual, and I made them a quick sprite. The images now have my editor's metadata. I don't expect these to stay as-is so I did not bother optimising them further. The stars required changes to the regular seven shortcut actions too, so did that quickly too.
I see the bordered background thing behind the text for shortcuts is mostly gone, there were minor leftovers. However, the star itself looks good / swaps color when hovered over, the text display is pretty clumsy. The design does not really have anything for this, so I'm not sure how best to fix.
Overlay with new close button and star:
Page which is not in shortcuts (gray star):
Page in regular backend Seven theme with star:
Comment #10
Gábor HojtsyBetter than a 0 bytes patch :D
Comment #11
Gábor HojtsyBojhan had several problems with the tabs (colors, borders, etc.) See http://drupal.org/node/1945542#comment-7226540 for chatlog. Style may be better resolved there first.
Comment #12
tkoleary CreditAttribution: tkoleary commented@gabor Hojtsy
A subtle changes that align better with the intent of the design* (bolded):
#overlay-tabs-secondary li a:active, #overlay-tabs-secondary li.active a {
border-bottom: 2px solid #0074bd;
color: #000;
}
*ry5n please correct me if I'm misinterpreting
Comment #13
Gábor HojtsyUploading images based on feedback from lewisnyman that it did not properly apply for him.
Comment #14
Gábor HojtsyRerolled against current Drupal 8 head.
Comment #16
Gábor Hojtsy#14: seventy-eight-overlay-restyle-14.patch queued for re-testing.
Comment #18
Gábor HojtsyIncorporated changes from @ry5n from #1945542: Add Navigation Tabs however most of what that did is it broke the placement of things. I needed to add a new wrapper for all of the tabs to accommodate for the system there, and otherwise carried over the suggested styles. For some reason the tabs will not take up as much as vertical space as intended though... Did not manage to track this down although probably pretty simple. @ry5n, @jbeach can you help? :)
If you make the overflow: hidden removed from the list, it shows the items got things disappear above/below the area that can be seen.
All I did is I incorporated ALL the changes from http://drupal.org/node/1945542#comment-7240378 from @ry5n based on the interdiff posted there. I attempted to take @tkoleary's suggestion above but that was not compatible with the latest setup from @ry5an. I did not cross-check these with Bojhan's review assuming @ry5n already did that, although he did not state that. I also did not cross-check with #1945556: Add Overlay and Modal components, I've been told that uses the same styling that the prior version of this patch did.
Comment #19
jessebeach CreditAttribution: jessebeach commentedFrom the styleguide, it seems that the tabs don't have overhanging pieces.
The image above is a screenshot from the Seven Styleguide: http://groups.drupal.org/node/283223
Comment #20
jessebeach CreditAttribution: jessebeach commentedI took a shot at the CSS to make it look more like the styleguide.
Comment #21
LewisNyman CreditAttribution: LewisNyman commentedBojhan mentioned on IRC that the current style looked bad with Bartik in the background, the blue does not mix well with the overlaid colors.
This patch includes a minor edit to the Bartik CSS to make the theme grayscale when the overlay loads, just as a proof of concept.
Screenshot attached
Comment #22
LewisNyman CreditAttribution: LewisNyman commentedBojhan mentioned on IRC that the current style looked bad with Bartik in the background, the blue does not mix well with the overlaid colors.
This patch includes a minor edit to the Bartik CSS to make the theme grayscale when the overlay loads, just as a proof of concept.
Screenshot attached
Comment #23
ry5n CreditAttribution: ry5n commentedSo as I mentioned in the sandbox issue, I want to propose a simplified version of the tabs. They’ve always felt heavy on the UI chrome, with extra borders and finicky bits. And it’s causing implementation headaches. So here’s something simpler, and I think better:
Observations:
- Far easier to implement
- Looks cleaner
- Is basically what we currently have on drupal.org, so I doubt the more minimal style will cause usability issues.
- Spacing between tabs could be a tiny bit tighter, but I don’t want to waste any more time in Photoshop
Comment #24
jessebeach CreditAttribution: jessebeach commentedI really like the simplification of the visual ornaments in #23.
Comment #25
tkoleary CreditAttribution: tkoleary commented@ry5n
Looks much better. Great work.
Comment #26
jessebeach CreditAttribution: jessebeach commentedfalcon03 asks that we move the tabs inside the
#overlay-content
div.#1964880-2: Convert the Overlay close button from an anchor element to a button element.
Comment #26.0
jessebeach CreditAttribution: jessebeach commentedUpdated issue summary.
Comment #27
Bojhan CreditAttribution: Bojhan commentedNow part of #1986434: New visual style for Seven - can we get an updated patch for this?
Comment #28
Gábor HojtsyMy understanding above from ry5n's post was that the style of the design to implement is still in discussion and this is not really actionable to implement yet. See #23.
Comment #29
Bojhan CreditAttribution: Bojhan commented@Gabor Nope, you can push forth with the design now. Me, roy and r5yn agreed upon the direction provided in http://drupal.org/node/1490402#comment-7406260
Comment #30
Bojhan CreditAttribution: Bojhan commentedRaising priority, this will significantly simplify the styling of the modal that still needs to be done and fix a major usability issue with tabs going unnoticed.
Comment #31
Gábor HojtsyBojhan: the tab design in #1490402-62: Redesign tabs and the content header looks considerably different from what was proposed above. Also its display in the rounded overlay top bar would looks interesting with the boxed links, no? I wanted to look at rerolling this patch based on your suggestion but I still don't see if there is a clear direction(?!)
Comment #32
Gábor HojtsyThis is a patch rerolled from Lewis' #21. Now we need people who care enough about this getting into core to be involved.
Comment #33
Gábor HojtsyThis is how it looks. Nothing surprising here.
Comment #34
Gábor HojtsyWhat this needs at least IMHO:
- Whether this visual look is what we want. The tabs design/behavior that Bojhan linked to is not what is implemented here.
- CSS / HTML code review (mostly CSS)
- Replacement for the icons added here, those are not licensable under GPL, just for prototyping
Comment #36
David_Rothstein CreditAttribution: David_Rothstein commentedLooks beautiful, but I don't see how the breadcrumbs can just be removed like that? (There are tons of admin interfaces in core, and even more in contrib, where you can navigate your way in and then would have no way back to where you were without the breadcrumbs to help you. For previous discussion of this issue, see #548806: No breadcrumbs in Seven.)
Maybe there's a way to add them back but have them be de-emphasized in the design?
Comment #37
tkoleary CreditAttribution: tkoleary commentedDavid_Rothstein:
I have a design for that. I will find it and add to the issue.
One other thing, I am concerned about the transparency in the header. Visually it's not really as attractive as the original designs *and* depending on what it is on top of it can cause legibility issues. I'm leaning towards wanting to take it out.
Comment #38
LewisNyman CreditAttribution: LewisNyman commentedWe don't have an official standard but it would be good stick to rgba if that's used elsewhere.
We can bring these into one property.
Let's change this to a class "overlay__title-wrapper"
This should be a class "tabs--overlay" I think
We have some icon sprites already in Seven, maybe we should just use those for now?
It looks like we've made this selector more specific then it was before, is there a reason for this?
Comment #39
Gábor HojtsyI'm not sure we should reform all the classes here too. Eg. id="overlay-title-wrapper" pre-exists this patch. We just move it around.
In terms of why the updated specificity in seven's styling for tabs is needed, that is because we now use the base theming for tabs to be on two levels. The overlay tabs are only different in terms of their wrapper not in the classes directly used on the primary and secondary tabs. If seven keeps using ul.primary, ul.secondary as selectors, then it will apply to the overlay tabs and we need to do an ungodly amount of style undoing. We can alternatively also introduce a theme function for tabs that is overlay specific, but the core one is in menu.inc/theme.inc and is supposed to be used system-wide I think. The code before this patch does not use that, because the overlay used to expose only the first level of the tabs and the second level was added to the page. Now both levels are excluded from the page and both levels are added on the overlay level.
Comment #40
LewisNyman CreditAttribution: LewisNyman commentedI think once we have the base Seven tabs implemented we'd have a parent varient class,
tabs-primary--overlay
, similar to the progress bar example. See the changes for.progress-bar__small
.It's hard for me to review the CSS if we are not taking into account all of the new standards. We can split it off into a follow up issue I guess?
Comment #41
Gábor HojtsyMy focus was on implementing the visual look with as minimal changes to the CSS/markup as possible. I'm happy for someone else to take the lead on taking this forward if a bigger scope is needed. To me it sounded like this already had a scope big enough that people were shy to get involved.
Comment #42
ry5n CreditAttribution: ry5n commentedLast I checked I had stalled things on account of the tabs. I proposed a new interaction for small screens in Redesign Tabs for Touchscreens.
Assuming we want to use that interaction design, here is a revised style (almost identical to #23) but with all the variants and states taken into account. (If the image below looks confusing, try the prototype, it should make things clearer).
Photoshop source is available: Download PSD
Comment #43
Bojhan CreditAttribution: Bojhan commented@r5yn I am not sure about this. The earlier design has a lot more hierarchy, that is now lost when you make the options blend in with the background. The only thing I would focus on improving is the indicator you have opened the tray. Also for sake of progress, could we get a first iteration in? This is a fundamental improvement, and I am afraid if we keep iterating endlessly in this thread no one will have the idea that we can move parts of this in.
The gradient is a bit misleading, obviously we do not want there to actually be a gradient.
Comment #44
ry5n CreditAttribution: ry5n commentedYes, no gradient. Which version do you want to go with? EDIT: I assume you mean the one in the issue summary.
After considering it, I’m OK with moving forward with the original design for the sake of progress (unless a bunch of people express a preference).
Comment #45
tkoleary CreditAttribution: tkoleary commented@ry5n
I would not give up so quickly on this one. This is a simplification that removes quite a bit of visual noise from the UI with zero usability loss as far as I can see. You have my vote for pushing forward on it, especially since it only involves removing—not adding—code.
Awesome work.
-Kevin
Comment #46
Gábor HojtsyThere is a lot more to the overlay patch than just the tabs. We keep focusing on the tabs questions and ignore solving the rest of the issues(?) I think there are enough details that we need to solve here that maybe we don't want to discuss and perfect everything in detail at once here?
Comment #47
ry5n CreditAttribution: ry5n commentedI think the updated tabs design is better, but it does not sound like we have consensus on that. Gábor is right: let’s get this moving again, and hopefully we have time to make a choice later about the tabs.
Comment #47.0
ry5n CreditAttribution: ry5n commentedmeta issue added
Comment #48
tkoleary CreditAttribution: tkoleary commented@ry5n
Sounds sensible.
BTW Jesse beach just saw your tabs prototype and pronounced it "damn sweet"
Comment #49
Gábor Hojtsy#32: overlay-restyle-32.patch queued for re-testing.
Comment #51
Gábor HojtsyHere is a direct reroll of the patch from #32 (last one) based on request from @tkoleary. I think given the pace of change in these files, and the number of things this patch touches, trying to limit ourselves in revamping the whole thing would be better. Unless someone wants to take full ownership of this, which would be amazing :)
Comment #52
Gábor Hojtsy- Changed the wrong shortcut.png above for some reason...
- Also fixed two background styles that crept in for secondary tabs
- The close button path not properly set with the images moved to an images folder
Comment #53
Gábor HojtsyStill looks the same as in #33 above. I uploaded a new screenshot I just made, but it looks exactly the same, so not embedding :) Now let's focus on getting icons that we can ship with legally and cleaning it up to get in? Then iterate on it as needed. Its a big and very interdependent beast that is better not kept endlessly rerolled until it gets moved to Drupal 9.x.
Comment #54
tkoleary CreditAttribution: tkoleary commented@Gábor Hojtsy
I think this is very close to being done. I only see a couple of things that need to be changed.
/* Remove the active state background from the secondary tabs */
#overlay-tabs ul.secondary a
- border-bottom: 1px solid transparent;
+ border-bottom: 2px solid transparent;
+ background: transparent;
}
And if we want to remove the styling on inactive tabs as in Ryan's design:
/* Remove the background from the parent */
#overlay-tabs {
- background-color: #ffffff;
+ background: transparent;
}
/* Remove the borders from the primary tabs */
#overlay-tabs ul.primary a {
- border-top: 1px solid #b3b3b3;
- border-left: 1px solid #b3b3b3;
}
/* Remove the background color and borders from the containing div */
#overlay-tabs ul.primary {
- background-color: #f2f2f0;
- border-radius: 5px 5px 0 0;
- border-top: 1px solid #b3b3b3;
}
/* remove the background color from the inactive tab and change the link color to contrast with the header background */
#overlay-tabs ul.primary a:hover {
- background-color: #fff;
+ background: transparent;
- color: #007ac7;
+ color: #8DD2FF;
}
/* add a hover color for the primary links and make it fade on */
#overlay-tabs ul.primary a:hover {
+ color: #fff;
+ -webkit-transition: all 1s;
}
/* add back white background but to secondary links only */
#overlay-tabs ul.secondary {
+ background-color: #ffffff;
}
Comment #55
Bojhan CreditAttribution: Bojhan commentedKevin could you provide the icons?
Comment #56
Gábor HojtsyI *think* these are the changes @tkoleary suggested but the syntax of his pseudo-diff that was made up above was not trivial to parse. Eg. some section repeated, some section denoted new selectors, some changes to existing ones. The resemblance to actual diffs made it even harder to figure out it was not supposed to be understood as a diff (eg. the comments in the snippets were not to be added or found in the CSS, they were commenting on what changes were being proposed).
Comment #58
Gábor HojtsyOf course it did not apply anymore to head, why would it.
Comment #59
Gábor HojtsyDoh, tabs lost in conflict resolution.
Comment #60
Gábor HojtsyVisual state of current patch (additionally to I'm not being sure there was/is an agreement that this tab style was supposed to be implemented?):
Comment #61
tkoleary CreditAttribution: tkoleary commented@Gábor Hojtsy
Ah. I think I missed a couple of attributes.
#overlay-tabs ul.primary .active ~ li a {
- border-left: 0;
- border-right: 1px solid #b3b3b3;
- border-radius: 0 5px 0 0;
}
#overlay-tabs ul.primary {
+ padding-left: 1em;
}
#overlay-tabs ul.primary a {
- color: #0074bd;
+ color: #8DD2FF;
}
The active and hove colors in the secondary tabs match the style guide.
Comment #62
tkoleary CreditAttribution: tkoleary commentedAnd this:
#overlay-tabs ul.primary .active a {
- border-right: 1px solid #b3b3b3;
- -webkit-box-shadow: 2px -1px 2px -1px rgba(0, 0, 0, 0.2), -2px -1px 2px -1px rgba(0, 0, 0, 0.2);
- -moz-box-shadow: 2px -1px 2px -1px rgba(0, 0, 0, 0.2), -2px -1px 2px -1px rgba(0, 0, 0, 0.2);
- box-shadow: 2px -1px 2px -1px rgba(0, 0, 0, 0.2), -2px -1px 2px -1px rgba(0, 0, 0, 0.2);
}
Comment #63
Gábor HojtsyI'm not sure those style suggestions lead to something useful? The color looks better, but the padding? I don't think so.
So did not take the padding, btu took the other two suggestions which seem fine. This way the tabs still line up with the secondary links (unlike with the added padding) and otherwise it looks reasonable too. Current patch screenshot:
Comment #64
tkoleary CreditAttribution: tkoleary commented@Gábor Hojtsy
I see. I can fix that. I need to add a first child element.
Comment #65
Bojhan CreditAttribution: Bojhan commentedDarn images dont load on my phone, probally wont be able to review till I am back from vacation. Not sure about the struggels the redesign should be pretty clear, if you need a clear updated psd i am sure that can happen.
Comment #66
Gábor HojtsyApplied the only outstanding suggestion from #62. Also moved the tabs into the overlay-child.css file instead of using an @import, which was just a temporary measure earlier. (Did not include that in the interdiff since that would obscure the actual change). The only visual change is that the tabs don't get a drop shadow anymore (which was this confusing blue looking but not actually blue thing that I noticed before on the side of active tabs).
Comment #67
LewisNyman CreditAttribution: LewisNyman commentedComment #68
LewisNyman CreditAttribution: LewisNyman commented#66: overlay-restyle-66.patch queued for re-testing.
Comment #70
LewisNyman CreditAttribution: LewisNyman commentedQuick reroll.
Comment #71
echoz CreditAttribution: echoz commentedLooking gorgeous! Only found this glitch noted in the 1st screenshot. Only added margin: 0; padding: 0; to #overlay-tabs to resolve, 2nd screenshot.
Also, notice in the patches there's a pretty big rdf tag for the images, looks like added by the graphics program. Never seen this in our patches before, I would think we need to save the images without it.
Comment #72
LewisNyman CreditAttribution: LewisNyman commentedThis is a tricky patch, it relies on components that have been implemented from #1490402: Redesign tabs and the content header and #2022695: Content header style update. In this issue we've actually re-implemented components from both of those sections.
I've tagged all these issues with 'styleguide-navigation', just to group them for now, it's likely they will be committed together as one patch. I've created a Seven Style Guide Initiative sandbox that includes all of the style guide issue patches. It also includes a branch that merges together all three navigation issues. I've created a patch from that branch against 8.x. It's totally broken, but hopefully it's a better base to work from.
Comment #73
LewisNyman CreditAttribution: LewisNyman commentedOk, so the RTL patch of doom knocked everything for six. Prior to that I experimented with the theming for the overlay tabs and realised I could get them looking pretty good without any custom styling. There is still work to do but it's not nearly as much as we were doing before.
The sandbox branch this is based off is: navigation-2022685-1490402-1953374
Comment #74
Gábor HojtsyLewis: looking forward for your updates!
Comment #75
LewisNyman CreditAttribution: LewisNyman commentedhm, I think I forgot to attach the patch with the last post... I had to remerge everything again anyway
Still some work to do here, most noticeably the add to favourites icon.
Comment #76
Bojhan CreditAttribution: Bojhan commented@Lewis I am reviewing this, am I correct the tabs are not styled like the style guide?
All other aspects look fine, the only thing I am contemplating whether we should ditch the transparency and just have a gray top.
Comment #77
LewisNyman CreditAttribution: LewisNyman commented@bojhan A lot of the work to get to the latest patch was to merge the overlay work with the latest patch in #1490402: Redesign tabs and the content header. I removed all overlay specific tabs styling to give us a better view of what we need to add in. We aren't that far off
You might need to be more specific when referencing the style guide, I'm not sure if we have a complete canonical version anymore, the most recent designs are in this issue, we should be working towards that right?
Comment #78
Gábor Hojtsy#75: overlay-restyle-1953374-72.patch queued for re-testing.
Comment #79
Gábor HojtsyPatch does not seem to apply anymore. @Bojhan: any way you can help move this forward? :) You posted some concerns 3 weeks ago and did not yet follow up on that.
Comment #81
LewisNyman CreditAttribution: LewisNyman commentedHere's an attempt at a re-roll.
Comment #82
tkoleary CreditAttribution: tkoleary commented@LewisNyman
Looking pretty good. Some small issues:
Drop-button overflow is hidden
Responsive tabs not working correctly
Border-left on first child tab looks odd
Comment #83
webchickDoing a bit of housekeeping on the Spark queue in order to re-familiarize myself with it, and this doesn't look strictly related to me. Tentatively removing tag.
Comment #84
tkoleary CreditAttribution: tkoleary commented@LewisNyman
Bug from #82 is fixed ( ... no longer kicks up to the top right) but the tabs still break at under 320px. Try using the elipsis then tabbing to a different tab.
Comment #85
LewisNyman CreditAttribution: LewisNyman commented@tkolery I don't consider that bug, the overlay should never open for mobile users, opening it in a desktop browser and resizing to a mobile width isn't a use case I considered supporting, I'm open to being convinced though, if you think it is a genuine use case.
Comment #86
tkoleary CreditAttribution: tkoleary commented@LewisNyman
Right. Good point. I should be testing in xcode.
Comment #86.0
tkoleary CreditAttribution: tkoleary commentedupdated related issues for meta
Comment #87
Bojhan CreditAttribution: Bojhan commentedGoing to mark this RTBC. Looks like Kevin his issues are resolved in all the other issues.
Comment #88
David_Rothstein CreditAttribution: David_Rothstein commented#81: overlay-restyle-1953374-81.patch queued for re-testing.
Comment #89
David_Rothstein CreditAttribution: David_Rothstein commentedDoesn't look like the patch applies... but also, does this still have the breadcrumb problem (see #36 and #37)?
Comment #91
LewisNyman CreditAttribution: LewisNyman commentedThe last patch was mega old. I've re-rolled it against the patch of #1490402: Redesign tabs and the content header #2022695: Content header style update.
Comment #92
LewisNyman CreditAttribution: LewisNyman commentedComment #93
LewisNyman CreditAttribution: LewisNyman commentedScreenies:
Comment #94
webchickI wonder if it's worth restoring the breadcrumbs and splitting the discussion about removing them into a separate issue. I'd hate to see this really nice styling get held up by a re-hash of the discussion that already happened in #548806: No breadcrumbs in Seven about this in D7. (The original version of Seven also intentionally didn't have breadcrumbs, for probbaly the same reasons as the Seven Style guide folks want to remove them, but it was deemed too difficult to navigate out of most admin pages which tend to be buried 2-3 levels deep.)
Comment #96
LewisNyman CreditAttribution: LewisNyman commentedAgreed, although you could argue that the new toolbar fills that role, I'd rather that discussion did not block these three issues. I'll reopen #2022695: Content header style update.
Bojhan said that he would be happy for the breadcrumbs to sit below the secondary tabs for now, which would be nice as we wouldn't have to go back to design to figure out how to accommodate them in the content header.
Comment #96.0
LewisNyman CreditAttribution: LewisNyman commentedAdded tabs
Comment #97
LewisNyman CreditAttribution: LewisNyman commentedForgot to close this http://media1.giphy.com/media/n5NHEm5gkuml2/giphy.gif