We've got this code in commerce order ui module: 

/**
 * Implements hook_menu_alter().
 */
function commerce_order_ui_menu_alter(&$items) {
  // Transform the field UI tabs into contextual links.
  $items['admin/commerce/config/order/settings/fields']['context'] = MENU_CONTEXT_PAGE | MENU_CONTEXT_INLINE;
  $items['admin/commerce/config/order/settings/display']['context'] = MENU_CONTEXT_PAGE | MENU_CONTEXT_INLINE;
}

And it's actually not being used and creating "fake" menu entries as commerce order entity is "single bundled".

Patch attached

CommentFileSizeAuthor
commerce_order_ui-unnecessary_menu_alter.patch822 bytespcambra

Comments

rszrama’s picture

rszrama commented
Status: Needs review » Active

I don't think we can be sure it isn't being used. We designed the Order module to support multiple order bundles without actually implementing a UI for it (there were just too many unknowns and we needed a 1.0), but we left the door open for people to do so in their own modules. The module http://drupal.org/project/commerce_order_types likely uses this code (if it's been implemented properly), and I've heard of custom development on sites to support multiple order bundles.

It's probably best to leave this code in, but I'm curious to know how these fake menu entries appear to you. I don't notice anything in the UI or Admin Menu. Do you have a screenshot or something?

pcambra’s picture

pcambra
he/him
Primary language Spanish
commented
Status: Active » Needs review

Yeah, thought about the commerce order types module before opening this one, but the code removed by this patch is not implementing anything useful for that module as commerce order types is providing its very own url for admin UI anyways (admin/commerce/config/order-types/' . $type_arg).
So default commerce order context/inline menus aren't displayed there and neither it is the default order bundle. See:

http://drupalcode.org/project/commerce_order_types.git/blob/refs/heads/7...

There's no UI consequence of leaving these but if you expose your items array, you'll get a couple of context keys floating out there without a proper menu item.

rszrama’s picture

rszrama commented
Status: Needs review » Fixed

Ahh! I see now. What I was missing above is that our field URLs for orders don't use the settings path argument anyways. Not sure if we ever intended to or if we just screwed up the copy / paste to get this alter in there in the first place. Either way... it's out now. Thanks Pedro. : )

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.