The enabled column should come before the expanded column on the menu admin page so it's easier to read.

This patch also removes the 'has children?' check for ticking the expanded checkboxes. A menu item can still be set to expanded even if it has no children.

Another issue is that status messages are non-existent for adding or editing a menu or menu item, but that's out of my league. Maybe someone else could help out with that?

CommentFileSizeAuthor
#8 menu_touches.patch1.45 KBRowanw
#8 menu_columns_01.png - proposed by Senpai21.36 KBRowanw
#8 menu_columns_02.png - with current patch20.94 KBRowanw
menu_touches.patch1.48 KBRowanw

Comments

Rowanw’s picture

Rowanw commented
Title: Usability: Adjust menu columns order and tick expanded checkboxes » Usability: Rearrange menu columns and tick expanded check boxes
senpai’s picture

senpai commented

Works as advertised, with no ill effects. Before I RTBC, I wanted to ask the Collective if disabling the Expanded checkbox for menu items who have no children would be a good idea.

We could do this at drupal_render time by checking for the existence of child elements, and setting the checkbox to 'disabled' inside the theme function so that it can be overridden by designers if necessary. Good idea, or bad idea?

Crell’s picture

Crell commented

-1 to removing the "expand" checkbox if a menu item has no children. Just because it doesn't now doesn't mean it won't have them added in the course of using the site. I may want to set up menus that should expand once content gets added. I don't want to have to come back and set it again.

Rowanw’s picture

Rowanw commented

Ditto for #3, that was the whole reason I made the change.

senpai’s picture

senpai commented

I wasn't referring to removing the 'expanded' checkboxes, but merely disabling them if the menu item doesn't have any children. Ok then. No support for that idea.

Since that doesn't fly, how about moving the 'enabled' column to position #1? It makes a LOT of sense from a user interface perspective that if the first column is a known width then we could have the two most important things on the page, the 'enabled' boxes and the 'draggable' icons, right next to each other. Yeah?

Crell’s picture

Crell commented

Might that be confusing for the DnD functionality? You'd have an extra checkbox sitting between you and the label you're targeting for the drop-target.

senpai’s picture

senpai commented

Hmmm, possibly, but probably not. I might just do this and see how it looks. I'm betting that with the proper theming, it won't be bad at all. Functional is the point here, after all.

Rowanw’s picture

Rowanw commented
StatusFileSize
new menu_columns_02.png - with current patch20.94 KB
new menu_columns_01.png - proposed by Senpai21.36 KB
new menu_touches.patch1.45 KB

Updated patch to latest release (had 2 lines offset).

I tried Senpai's idea to put the enabled column first, but since it sits between the move icons and the menu names it looks quite confusing, see attached PNG. If the checkbox was before the move icon it might look a little better, but that opens up inconsistencies with other D&D areas within Drupal. For this reason I think the columns should stay as they are in the current patch.

Patch summary again:

  • Always check the expanded checkboxes when they are set to expanded, regardless of the presence of children
  • Bring the enabled column before the expanded column
scoutbaker’s picture

scoutbaker commented

While, in theory, I like the idea of having the Enabled column first, I agree with Rowanw that it looks a little odd from a usability perspective. It's easier for me to visualize what I'm moving when the Enabled column is second.

pancho’s picture

pancho
Location UTC+2 🇪🇺 EU
commented

+1 The patch in #8 seems to be good.

I wouldn't move the enabled checkbox to the front either. Aside from D'n'D drawbacks this would also imply, disabled menu items wouldn't play any role, which is not the case.

Rowanw’s picture

Rowanw commented
Status: Needs review » Reviewed & tested by the community

RTBC?

gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented
Status: Reviewed & tested by the community » Fixed

Committed, thanks.

Anonymous’s picture

Anonymous (not verified) commented
Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.