To my opinion the module can be integrated better with Feeds.
For a start, drop the database table and make use of parent functions.

I ran into this problem due to the GUID which the module implements itself.
The GUID was not stored in the feeds_item table.

Hereby a little rework on the module without the db table and better integration.
Still needs works though, but its closer to Feeds than the original. (No offense, Dane Powell started a very good initiative and base)

Am open to suggestions and patches.

CommentFileSizeAuthor
#6 feeds_comment_processor-feeds_item-table-1947604-6.patch9.57 KBtwistor
#5 feeds_comment_processor-feeds_item-table-1947604-5.patch8.65 KBtwistor
#4 feeds_comment_processor-feeds_item-table-1947604-4.patch8.98 KBtwistor
#1 feeds_comment_processor.zip3.32 KBaoturoa
feeds_comment_processor.zip3.56 KBaoturoa

Comments

aoturoa’s picture

aoturoa commented
StatusFileSize
new feeds_comment_processor.zip3.32 KB

A few fixes and removed the 'comment_submit' function before saving.

aoturoa’s picture

aoturoa commented
Issue summary: View changes

Added Thank You to original initiative.

twistor’s picture

twistor commented
Title: Optimize integration with Feeds and drop the db table. » Remove feeds_comment_item table.
Issue summary: View changes

Yes, this should be done. But, it needs to be done in a patch.

twistor’s picture

twistor commented
Assigned: Unassigned » twistor

Gonna knock this out.

twistor’s picture

twistor commented
Status: Needs work » Needs review
StatusFileSize
new feeds_comment_processor-feeds_item-table-1947604-4.patch8.98 KB
twistor’s picture

twistor commented
StatusFileSize
new feeds_comment_processor-feeds_item-table-1947604-5.patch8.65 KB

Didn't mean to remove the comment target.

twistor’s picture

twistor commented
StatusFileSize
new feeds_comment_processor-feeds_item-table-1947604-6.patch9.57 KB

ExpiryQuery is only available in feeds-dev, so copy expire() method.

  • twistor committed 20a67ed on 
    Issue #1947604 by twistor: Remove feeds_comment_item table
twistor’s picture

twistor commented
Assigned: twistor » Unassigned
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.