Oh no need to apologize, at all. Please create them to your hearts content :) I live for issues lol You're absolutely correct in that modules only get better if they're created.
This is a very valid bug though and a conundrum. I was able to reproduce this on simplytest.me as well. The JS halts on the page because of this error I found in the console:
Uncaught TypeError: Object #<Object> has no method 'on'
Now, the question is. Should Fontello be dependent on jQuery Update or be refactored to work out of the box with core (jQuery 1.4.4). Honestly, I think the latter might be necessary as things like this #1766240: Option to limit Jquery Update scope to front end only exist (I have used this on a few projects). That means that it could still be possible that administrative paths could only load the jQuery 1.5 version, instead of 1.7.
Just did some more digging, they apparently pushed this alternative administrative jQuery version into the 2.x branch recently: #1524944-107: Allow different version for administrative pages. So it is now a much higher probability that this could have repercussions for modules like this. Looks like Fontello's JS might need to be refactored.
» Create a better UI to handle bundle/icon selections
Category:
bug
» task
The minimum jQuery 1.7 is no longer an issue. I want to really re-think how Icon API handles/implements the UI aspect of the icon selector though, so I'll leave this issue open for now.
Comments
Comment #1
markhalliwellOh no need to apologize, at all. Please create them to your hearts content :) I live for issues lol You're absolutely correct in that modules only get better if they're created.
This is a very valid bug though and a conundrum. I was able to reproduce this on simplytest.me as well. The JS halts on the page because of this error I found in the console:
Uncaught TypeError: Object #<Object> has no method 'on'This method was introduced in jQuery 1.7 (http://api.jquery.com/on/). Try adding jquery_update and configuring setting the jQuery version to 1.7 from the Google CDN (http://simplytest.me/project/fontello?add[]=jquery_update). I was able to get it to work then.
Now, the question is. Should Fontello be dependent on jQuery Update or be refactored to work out of the box with core (jQuery 1.4.4). Honestly, I think the latter might be necessary as things like this #1766240: Option to limit Jquery Update scope to front end only exist (I have used this on a few projects). That means that it could still be possible that administrative paths could only load the jQuery 1.5 version, instead of 1.7.
Comment #2
markhalliwellJust did some more digging, they apparently pushed this alternative administrative jQuery version into the 2.x branch recently: #1524944-107: Allow different version for administrative pages. So it is now a much higher probability that this could have repercussions for modules like this. Looks like Fontello's JS might need to be refactored.
Comment #3
markhalliwellMoving to the Icon API module per #1948240: [icon] Request re-purpose/ownership change
Comment #4
markhalliwellUpdated version, didn't allow me to select the right one before.
Comment #5
markhalliwellThe minimum jQuery 1.7 is no longer an issue. I want to really re-think how Icon API handles/implements the UI aspect of the icon selector though, so I'll leave this issue open for now.
Comment #6
decipheredClosing as a duplicate of #2370899: Show icon on icon_selector dropdown list