In tweet.tpl and twitter_views_field_handlers.inc there are hardcoded text strings, Reply, Retweet, Favorite and Follow

I have fixed this in the attached patch :o)

CommentFileSizeAuthor
#12 twitter-n1943728-12.patch3.49 KBDamienMcKenna
#5 interdiff.txt1.03 KBplopesc
#5 translations-1943728-5.patch3.22 KBplopesc
#3 translations-1943728-3.patch2.92 KBplopesc
#2 twitter-7.x-5.6.patch2.61 KBfrankdk
twitter.patch2.59 KBfrankdk
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

juampynr’s picture

juampynr CreditAttribution: juampynr commented
Status: Active » Needs work 
+++ twitter_patched/tweet.tpl.phpundefined
@@ -32,12 +32,12 @@
+    "https://twitter.com/intent/tweet?in_reply_to=<?php print $status->twitter_id; ?>"><?php t('Reply'); ?></a></li>

Missing 'print' here and in the next two ones.

frankdk’s picture

frankdk CreditAttribution: frankdk commented
FileSize
twitter-7.x-5.6.patch2.61 KB

I have fixed the mixin print in the attached patch

plopesc’s picture

plopesc
he/him
Primary language Spanish
CreditAttribution: plopesc commented
Status: Needs work » Needs review
FileSize
translations-1943728-3.patch2.92 KB

Hello

Re-rolling patch avoiding the use of t() function in tpl files passing those values as theme function variables.

Regards.

plopesc’s picture

plopesc
he/him
Primary language Spanish
CreditAttribution: plopesc commented
Title: Hardcodet text strings » Hardcoded text strings
Version: 7.x-5.6 » 7.x-6.x-dev

I have tested lasta patch against 7.x-6.x branch and is applied cleanly too.
Marking issue for 7.x-6.branch, then it could be backported easily.
Regards

plopesc’s picture

plopesc
he/him
Primary language Spanish
CreditAttribution: plopesc commented
Issue summary: View changes
FileSize
translations-1943728-5.patch3.22 KB
interdiff.txt1.03 KB

I noticed there can be cache issues with text translations when hardcoding it in the hook_theme() declaration.
Re-rolling new patch.

DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna commented
Status: Needs review » Reviewed & tested by the community

Short & simple.

DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna commented
Parent issue: » #2402307: Plan for Twitter v7.x-5.9 release
DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna commented
Status: Reviewed & tested by the community » Needs review

Triggering the testbot.

DamienMcKenna queued 5: translations-1943728-5.patch for re-testing.

  • DamienMcKenna committed ec40b79 on 7.x-6.x authored by frankdk 
    Issue #1943728 by frankdk, plopesc: Some text strings weren't translated...
DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna commented
Status: Needs review » Fixed

Committed to 7.x-6.x.

DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna commented
Version: 7.x-6.x-dev » 7.x-5.x-dev
Status: Fixed » Needs review
FileSize
twitter-n1943728-12.patch3.49 KB

Rerolled for 7.x-5.x.

DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna commented
Status: Needs review » Fixed

Committed.

  • DamienMcKenna committed 2f6593c on 7.x-5.x authored by frankdk 
    Issue #1943728 by frankdk, plopesc: Some text strings weren't translated...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.