In plugins/views_data_export_plugin_display_export.inc outputfile_write() opens the export file that is being appending to during the processing of the view but doesn't close the file handle. The memory leak is minor, but it would still be a best practice I believe to call fclose(). Will attach patch.

CommentFileSizeAuthor
#1 views_data_export-missing_fclose-1943272-1.patch849 bytesjemond

Comments

jemond’s picture

jemond commented
Status: Active » Needs review
StatusFileSize
new views_data_export-missing_fclose-1943272-1.patch849 bytes

Patch attached.

Mołot’s picture

Mołot commented

All files are closed at the end of the script anyway (it's not C), so it's not a real problem, but closing them asap would be a tiny bit more efficient and a lot more elegant solution.

steven jones’s picture

steven jones commented

#1: views_data_export-missing_fclose-1943272-1.patch queued for re-testing.

steven jones’s picture

steven jones commented
Status: Needs review » Fixed

Thanks very much for the bug report and the patch. Applied, committed and pushed to 6.x-2.x.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.