I noticed an issue with Masonry where it was registering FALSE / NULL from PHP as empty, specifically for the isRTL js setting. On output that leaves a property that's undefined which breaks js as a syntax error --

isRTL: 
});

Other items on output typecast as int and I'm not sure if they are doing this to solve this issue or not but it does. To be safe against other possible defaults (particularly from Views imports) I've typecasted everything in this patch for all outputs.

CommentFileSizeAuthor
#1 masonry-typecast-booleans-for-js-1942824-1.patch3.56 KBbtopro
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

btopro’s picture

btopro CreditAttribution: btopro commented
Status: Active » Needs review
FileSize
masonry-typecast-booleans-for-js-1942824-1.patch3.56 KB
slucero’s picture

slucero
he/him
Primary language English
CreditAttribution: slucero commented

I was having this same issue and the patch fixed it perfectly. After reviewing the patch it looks like a straight-forward fix and a good solution.

Thanks @btopro!

davidfells81@gmail.com’s picture

davidfells81@gmail.com CreditAttribution: davidfells81@gmail.com commented

I just made these changes myself and came to check the issue queue to add an issue if there was not one. +1 to this, definitely fixes an issue breaking my site!

vzblk’s picture

vzblk CreditAttribution: vzblk commented

I see javascript error when try to use this view as exported and imported. By default FALSE converted to empty. So I see
isResizable: ,
isFitWidth: ,
in the initiaization script.
Please apply this patch to the project.

BWPanda’s picture

BWPanda CreditAttribution: BWPanda commented
Status: Needs review » Fixed

Thanks all! Committed: http://drupalcode.org/project/masonry.git/commit/f753908

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.