Expectation: Indicator block is shown on pages that have a checked box

CommentFileSizeAuthor
#3 issue-1942390-selecting-visibility-of-checkout.diff3.82 KBspiffl
#1 0001-fixes-issue-1942390-Selecting-visibility-of-checkout.patch5.32 KBspiffl
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

spiffl’s picture

spiffl CreditAttribution: spiffl commented
FileSize
0001-fixes-issue-1942390-Selecting-visibility-of-checkout.patch5.32 KB

Patch fixes the issue described by getting the same options as shown in the configuration of the block to mimick the "nothing is selected" means "everything is selected".

Patch is also available here:
https://github.com/beatchristen/commerce_checkout_progress/commit/d8bced...

jcisio’s picture

jcisio CreditAttribution: jcisio commented
Status: Active » Needs work

Could you remove unrelated changes so that the patch is easier to review?

spiffl’s picture

spiffl CreditAttribution: spiffl commented
Status: Needs work » Active
FileSize
issue-1942390-selecting-visibility-of-checkout.diff3.82 KB

I removed the unrelated changes, pull request is still valid:
https://github.com/beatchristen/commerce_checkout_progress/pull/1/files

spiffl’s picture

spiffl CreditAttribution: spiffl commented
Status: Active » Needs review
nvahalik’s picture

nvahalik CreditAttribution: nvahalik at Centarro commented
Issue summary: View changes
Issue tags: +sprint
joelpittet’s picture

joelpittet
Primary language English
Location Vancouver
CreditAttribution: joelpittet commented
Status: Needs review » Reviewed & tested by the community

I've been using this and it does the job. Thank you.

  • nvahalik committed 57f48fe on 7.x-1.x authored by spiffl 
    Issue #1942390 by spiffl: Selecting visibility of checkout panes hides...
nvahalik’s picture

nvahalik CreditAttribution: nvahalik at Centarro commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.