Task

Convert the following theme functions to use the new table #type:

Module Theme function name Where in Code What is it really?
forum theme_forum_list template
forum theme_forum_topic_list template

Related issues

Comments

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
commented
Assigned: Unassigned » larowlan

.

jibran’s picture

jibran
he/him
Primary language Urdu
Location Toronto, Canada
commented
Issue tags: +Novice

Tagging.

neochief’s picture

neochief commented
Status: Active » Closed (fixed)

It looks like these functions dont exist anymore and listing was replaced by views.

zhgenti’s picture

zhgenti commented
Status: Closed (fixed) » Closed (won't fix)
joelpittet’s picture

joelpittet
he/him
Primary language English
Location Vancouver
commented
Assigned: larowlan » Unassigned
Status: Closed (won't fix) » Needs work

Re-opening this because it has a tablesort_init call in there and a twig template file that shouldn't be needed.

The manually built header is calling a private function that also doesn't need to exist called '_theme_table_cell'

joelpittet’s picture

joelpittet
he/him
Primary language English
Location Vancouver
commented

Also this issue is holding up #1939008: Convert theme_table() to Twig a bit with an @todo.

joelpittet’s picture

joelpittet
he/him
Primary language English
Location Vancouver
commented
Status: Needs work » Closed (won't fix)
Issue tags: -Novice

Ok scrap that idea. #type table is kinda slow from a DX (@see #1876718: Allow modules to inject columns into tables more easily) and performance prospective(@see #1938926-18: Convert simpletest theme tables to table #type. Just going to change the forum bit that I need for #theme table and leave this closed.