Hi guys,

I just wanted to report a small/minor issue related with the install file of the module.

It seems module is not deleting any of the configuration variables upon uninstall.

  • reroute_email_address
  • reroute_email_enable_message
  • reroute_email_enable

Basically, we would need to add reroute_email.install with an implementation of hook_uninstall.

Please let me know if you would have any questions on any points/code/aspects mentioned in this ticket, I would surely be glad to provide more information.

Any feedback, comments, question, testing would be highly appreciated.
Thanks in advance.

CommentFileSizeAuthor
#2 Patch for 7.x-1.x to remove all configuration variables when reroute_email is uninstalled.537 byteswangqizhong
#2 Patch for 6.x-1.x to remove all configuration variables when reroute_email is uninstalled.537 byteswangqizhong

Comments

wangqizhong’s picture

wangqizhong commented
Assigned: Unassigned » wangqizhong

Hi guys,

I am interested in fixing this problem, so I will take the issue.
Changing assignment to: wangqizhong.

Please let me know if you would have any questions or comments, I would surely try replying as soon as possible.
Thanks!

wangqizhong’s picture

wangqizhong commented
Status: Active » Needs review
StatusFileSize
new Patch for 6.x-1.x to remove all configuration variables when reroute_email is uninstalled.537 bytes
new Patch for 7.x-1.x to remove all configuration variables when reroute_email is uninstalled.537 bytes

Quick follow up on this ticket.

Please find attached to this comment two patch files against all existing versions:

These two patches have been tested and seem to work as expected.

For all these versions, I didn't do any other change but to add an implementation of hook_uninstall in a new file called reroute_email.install to delete the configuration variables.

This change doesn't add any new feature or function to the module, however, it improves its code organization, readability, maintainability.

Please let me know if you would have any questions, objections, comments, suggestions, recommendations or concerns on the patch files or any aspects discussed in this ticket, I would be glad to provide more information, explain in more details or re-roll the patches if necessary.
I would greatly appreciate some help from module maintainers and if any of you could take a bit of time to look into any of the attached patches (6.x-1.x, 7.x-1.x) to give me your feedback/opinion on this ticket.
 
Any questions, feedback, testing, changes, recommendations would be highly appreciated.
Thanks to all in advance.

dydave’s picture

dydave commented
Status: Needs review » Fixed

Thanks a lot wangqizhong for this clean patch.
It looks good and seems to work well.

This change has been committed at: 6.x-1.x: 18639ef, 7.x-1.x: 0b3ce25.
Marking this as fixed.

Please let me know if you would have any other questions, comments, issues or concerns on any of these changes, I would be glad to provide more information.

Thanks again for your help and interest.
Cheers!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.