Files: 
CommentFileSizeAuthor
#10 revert-image-quality-1937140-10.patch1.8 KBBerdir
PASSED: [[SimpleTest]]: [MySQL] 53,086 pass(es).
[ View ]
#3 1937140-cmi-image_quality-drupal-3.patch1.8 KBACF
PASSED: [[SimpleTest]]: [MySQL] 52,490 pass(es).
[ View ]
#1 1937140-cmi-image_quality-drupal-1.patch1.78 KBACF
PASSED: [[SimpleTest]]: [MySQL] 52,510 pass(es).
[ View ]

Comments

ACF’s picture

Status:Active» Needs review
StatusFileSize
new1.78 KB
PASSED: [[SimpleTest]]: [MySQL] 52,510 pass(es).
[ View ]
aspilicious’s picture

+++ b/core/modules/system/image.gd.incundefined
@@ -296,7 +296,7 @@ function image_gd_save(stdClass $image, $destination) {
+    $success = $function($image->resource, $destination, config('image.settings')->get('jpeg_quality'));

I would split this in 2 lines.

ACF’s picture

StatusFileSize
new1.8 KB
PASSED: [[SimpleTest]]: [MySQL] 52,490 pass(es).
[ View ]
Berdir’s picture

Status:Needs review» Reviewed & tested by the community

And this looks good as well.

Dries’s picture

Status:Reviewed & tested by the community» Fixed

Committed to 8.x. Thanks!

sun’s picture

Status:Fixed» Needs work

Sorry, but this was not correct.

The image JPEG quality setting belongs to the Image Toolkit API. The Image Toolkit API does not belong to Image module and can be used without that module being installed.

We do not seem to have any config settings for image toolkits yet. The setting should be moved into a system.image.yml config file.

Berdir’s picture

Uh, sorry, my fault. I guess we can't really add useful test coverage here (explicitly checking the default values of all configuration is kinda pointless and it's hard to verify that a jpg was created with the correct quality I guess ;)).

#1664844: Convert image toolkits into plugins introduces "config('system.image')->get('toolkit')", I guess we could move it into the same system.image config file. Not worried about a conflict with that other issue, that already doesn't apply anymore anyway.

aspilicious’s picture

Status:Needs work» Closed (duplicate)

Ok I'm going to close this and crossreference the other issue.

sun’s picture

Category:task» bug
Status:Closed (duplicate)» Needs work

The proper status would be fixed, but I disagree with merging the two issues.

We should either revert the committed patch or quickly fix it up. I'd prefer the latter.

Berdir’s picture

Status:Needs work» Needs review
StatusFileSize
new1.8 KB
PASSED: [[SimpleTest]]: [MySQL] 53,086 pass(es).
[ View ]

I checked it and it seems to be complicated to fix as it's part of the plugin settings and is currently actually broken because the value is never saved. So here's a revert patch, I assume the other issue will take care of converting it propertly.

sun’s picture

Status:Needs review» Reviewed & tested by the community

I did not fully understand the reason, but rolling it back works for me, too.

webchick’s picture

Status:Reviewed & tested by the community» Closed (duplicate)

OK, rolled back. I guess then this becomes a duplicate on #1664844: Convert image toolkits into plugins?