Relation install fails to add endpoint field to types provided by the defaults hook

WFM, although I'm kind of surprised you can get away with just one test. Guess we can add more later. Do it!

Both https://api.drupal.org/api/drupal/modules!field!field.crud.inc/function/... and https://api.drupal.org/api/drupal/modules!field!field.crud.inc/function/... say that the field_info_* version is preferred, and they return the same thing, with extra info. So how about this instead:

Great mikran. Thanks for committing to this issue.

It was messing up my features. I had been trying to track down this issue for a while.

This breaks an install profile of mine that has relation types defined in code.
Here's the call stack:

[...]
relation_entity_info( ) ../module.inc:895
relation_get_types( ) ../relation.module:41
relation_type_ensure_instance( ) ../relation.module:345
field_create_instance( ) ../relation.module:303
_field_write_instance( ) ../field.crud.inc:512
field_info_max_weight( ) ../field.crud.inc:612
field_info_extra_fields( )	 ../field.info.inc:721
FieldInfo->getBundleExtraFields( ) ../field.info.inc:686
module_invoke_all( ) ../field.info.class.inc:454
call_user_func_array ( ) ../module.inc:895
entity_field_extra_fields( ) ../module.inc:895
entity_get_extra_fields_controller( ) ../entity.module:1346
EntityDefaultExtraFieldsController->__construct( ) ../entity.module:1365
entity_get_property_info( ) ../entity.info.inc:224
drupal_alter( ) ../entity.property.inc:39
relation_entity_property_info_alter( ) ../module.inc:1101
relation_get_types( ) ../relation.module:97
relation_type_ensure_instance( ) ../relation.module:345
field_create_instance( ) ../relation.module:303
_field_write_instance( ) ../field.crud.inc:512
field_info_max_weight( ) ../field.crud.inc:612
field_info_extra_fields( ) ../field.info.inc:721
FieldInfo->getBundleExtraFields( ) ../field.info.inc:686
module_invoke_all( ) ../field.info.class.inc:454
call_user_func_array ( ) ../module.inc:895
entity_field_extra_fields( ) ../module.inc:895

So basically, here's what happens:

1. Features get enabled by the install profile
2. Relation's hook_entity_info (relation_entity_info) is called.
3. relation_entity_info calls relation_get_types
4. relation_get_types calls relation_type_ensure_instance which creates the instance of the FIRST relation type
5. When the instance is created field_info_extra_fields is called (I think by drupal core code)
6. The entity module's hook_field_extra_fields (entity_field_extra_fields) is called.
7. entity_field_extra_fields calls entity_get_extra_fields_controller for each entity type
8. entity_get_extra_fields_controller looks like this:

  function entity_get_extra_fields_controller($type = NULL) {
    $static = &drupal_static(__FUNCTION__);

    if (!isset($static[$type])) {
      $static[$type] = FALSE;
      $info = entity_get_info($type);
      if (!empty($info['extra fields controller class'])) {
        $static[$type] = new $info['extra fields controller class']($type);
      }
    }
    return $static[$type];
  }
  

9. The 'extra fields controller class' defaults to EntityDefaultExtraFieldsController
10. $static[$type] in entity_get_extra_fields_controller stays FALSE until EntityDefaultExtraFieldsController's constructor has finished
11. EntityDefaultExtraFieldsController's constructor calls entity_get_property_info ($static[$type] is still FALSE)
12. entity_get_property_info calls relation_entity_property_info_alter ($static[$type] is still FALSE)
13. relation_entity_property_info_alter calls relation_type_ensure_instance which creates the instance of the SECOND relation type ($static[$type] is still FALSE)
14. When the instance is created field_info_extra_fields is called (I think by drupal core code) ($static[$type] is still FALSE)
15. The entity module's hook_field_extra_fields (entity_field_extra_fields) is called. ($static[$type] is still FALSE)
16. entity_field_extra_fields calls entity_get_extra_fields_controller for each entity type ($static[$type] is still FALSE)
17. Becuase $static[$type] is still FALSE entity_get_extra_fields_controller returns FALSE
18. And because of that I get: Fatal error: Call to a member function fieldExtraFields() on a non-object

Quite a long report but I hope it helps debug and fix the issue.