The bean label (description: "Name that displays in the admin interface") is used as the block title/subject.
The label is supposedly for admin interfaces, to describe the block.
This is different to the block title/subject.
This does not make sense for anyone used to drupal core blocks, where the administrative label is not used as the block title.
This is an issue because you need to be able to have an administrative label at all times but that isn't necessarily the title, which you might even want to leave blank/<none>.
Seems logical that the "Title" field would be used as the block title/subject always.
| Comment | File | Size | Author |
|---|---|---|---|
| #1 | bean-block_title-1935770-1.patch | 331 bytes | rooby |
Comments
Comment #1
rooby commentedPatch to fix.
Seems this was a regression during #1836798: Block Label used rather than Title on block/delta and block/delta/view, which was meant for bean_view pages, not block views.
Comment #2
rooby commentedPatch is for dev.
Comment #3
saltednutYeah - this problem was introduced a while back and its affecting things over here http://drupal.org/node/1916938#comment-7118094
Its not something we want to change on bean_block_view. I'm postponing this and deferring to the other issue to resolve the problem.
Comment #4
saltednutCommitted patch b from http://drupal.org/node/1916938#comment-7118094
We need to make a followup issue though to figure out why Entity->getTranslation is not working correctly in Bean.
Comment #5
james.williamsThanks for this, although I had to use the http://drupal.org/project/registry_rebuild project to rebuild my registry once I'd updated my bean module, as I couldn't reach update.php without hitting a fatal error that was looking for the old class name. Not sure of the solution, since bean module's update hooks are meant to fix this from the look of them!
Comment #6
saltednut@james.williams-
Strange - I did not encounter this during my tests.
Also, what does that have to do with this issue? (label is used as block subject)
I assume you were moving to a newer bean to fix this problem, but the issue with classes not being found should have more to do with http://drupalcode.org/project/bean.git/commit/53d9b34
Can you file a bug report about this regression? Thanks!
Comment #7
jpstrikesback commentedThe commit mentioned above does not correct the issue/regression that #1 fixes, bean_block_view() should not set the label as the block title ever as far as I can tell. Setting to a higher priority as this makes for some large pain when moving from dev - to test & live and needing to update each block title with
<none>to achieve no title. Perhaps #1 isn't the bean way to fix this but when would the bean block subject ever use the label?Comment #8
saltednutI'm not sure what you mean @jpstrikesback. The latest dev does not display the label where it should not. Please be more clear with what problem you are experiencing and make sure you are testing against the latest HEAD.
Also, setting something as 'major' because you find it annoying is no way to get the maintainers to work out your issue quicker.
Comment #9
jpstrikesback commentedHey Brantwynn,
I am experiencing the problem described by the OP. The symptom is that a bean block that has no title (none at all) shows the label. In bean_block_view() we set the block subject, which is what gets rendered as the block display title, to label(). See http://drupalcode.org/project/bean.git/blob/refs/heads/7.x-1.x:/bean.mod... from the latest dev.
I set it to major as it seems major, apologies if I am wrong.
Best,
JP
Comment #10
saltednutOkay - I am understanding this now and I've been able to replicate. I agree this is not a desired behavior and that Beans should never output the admin title (bean->label).
Thanks for clarifying, JP.
I've committed rooby's patch to dev. http://drupalcode.org/project/bean.git/commit/d4038e7
Comment #11
jpstrikesback commentedFantastic, Cheers!