Data comparison in Rules - order subtotal

The order grand total should technically include any discount, so what you need here is the subtotal of all products instead, which would ignore any discount (or indeed, any currently applied shipping quote). This is available as a token, but not as a an order property in Rules, so this is a feature request.

Attached patch provides rules conditions to compare order total and subtotal to a specified value.

• Added total comparison because stock rules data comparison does not provide >= and <= operators and it make life easier for rules noobs.
• Added generic function uc_order_condition_value_operator_comparision() to compliment uc_order_condition_value_operator_options().
• uc_order_condition_value_operator_comparision() can be used to further optimize code in uc_order_condition_count_products() and uc_order_condition_products_weight() by replacing switch ($op) {...

Updated patch - accidentally overwrote $value in foreach().

It's strange. I have used this patch before, but for some reason I was having the following error on a site:

Notice: Undefined property: stdClass::$total in uc_order_condition_total() (line 943 of /home/nubie/public_html/dev7/sites/all/modules/ubercart/uc_order/uc_order.rules.inc).

Only to find out that ->total is not actually a valid properly but rather order_total is.

Attached is a patch correcting this.

Uploading the interdiff with txt extension

Looks good to me, but "comparision" should be "comparison"

Since the patch adds a new function uc_order_condition_value_operator_comparision(), I think that function should also be used to replace the switch statements in uc_order_condition_products_weight() and uc_order_condition_count_products().

Can someone test this? It's the same as #4 but with my comments from #10 included.

And one more, this time with the rule labels changed slightly for consistency with our other rules.

Just providing an interdiff between 12 and 4.

Patch looks good!

Committed! Thanks all...

Moving to 8.x-4.x so we remember to forward port this ...

Cherry-picked it straight into the 8.x-4.x codebase, even if all the Rules conditions still need conversion at least it's in there.