This is pretty much a straight port of the same functionality from the numeric contextual filter handler. In my tests it worked fine both for single values, and when "Allow multiple values" was enabled - passing in multiple ORed values resulted in a NOT IN query.

CommentFileSizeAuthor
exclude-string.patch1.98 KBowen barton

Comments

madt’s picture

madt
Location Moscow
commented

exclude-string.patch queued for re-testing.

owen barton’s picture

owen barton commented

exclude-string.patch queued for re-testing.

Dean Reilly’s picture

Dean Reilly commented
Issue summary: View changes
Status: Needs review » Reviewed & tested by the community

This looks good to me and works as expected. Marking as reviewed & tested.

colan’s picture

colan
he/him
Primary language English
Location Toronto 🇨🇦
commented

We've recently switched our testing from the old qa.drupal.org to DrupalCI. Because of a bug in the new system, #2623840: Views (D7) patches not being tested, older patches must be re-uploaded. On re-uploading the patch, please set the status to "Needs Review" so that the test bot will add it to its queue.

If all tests pass, change the Status back to "Reviewed & tested by the community". We'll most likely commit the patch immediately without having to go through another round of peer review.

We apologize for the trouble, and appreciate your patience.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Reviewed & tested by the community » Fixed
Parent issue: » #2960871: Plan for Views 7.x-3.23 release

Committed. Thanks.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.