The views relationships provided by redhen_note need some love.

Most are impossible - "Note to Commerce Payment transaction" anyone?!

One I did expect to work was "Note to Engagement", but this one is not functional.

I will look into patching this today.

Thanks as always for the module!

Pete

CommentFileSizeAuthor
#6 redhen-notes-relationships-1930122-6.patch10.96 KBmicnap
#1 redhen-notes-relationships-1930122-1.patch10.63 KBPete B

Comments

Pete B’s picture

Pete B commented
StatusFileSize
new redhen-notes-relationships-1930122-1.patch10.63 KB

So some time passed, but as promised here is a patch for this. I address views relationships for Notes, Engagements and Engagement Scores. This allows proper relationships between these three related entities.

Thanks,
Pete

Pete B’s picture

Pete B commented
Status: Active » Needs review

Forgot to set needs review...

micnap’s picture

micnap commented

Applied cleanly except for the /modules/redhen_note/redhen_note.info file. For some reason it refused to add the "files[] = lib/redhen_note.views.inc" line. Also, I had to rebuild the registry because of the RedhenNoteViewsController class getting added. I was getting a fatal error saying that RedhenNoteViewsController didn't exist.

I also changed line 17 of modules/redhen_note/lib/redhen_note_views.inc from

if ($entity_type == 'redhen_contact') {

to

if ($entity_type == 'redhen_contact' || $entity_type == 'redhen_org') {

to give me the relationship between notes and redhen_org.

Seems to be working well.

Thanks,
Mickey

westberliner’s picture

westberliner commented
Status: Needs review » Reviewed & tested by the community

Tested the Patch with the modification from micnap. Worked fine within my redhen_note installation.

levelos’s picture

levelos commented
Status: Reviewed & tested by the community » Needs work

The patch needs to be re-rolled against head and include @micnap's changes from #3.

micnap’s picture

micnap commented
Status: Needs work » Needs review
StatusFileSize
new redhen-notes-relationships-1930122-6.patch10.96 KB

Here's a re-roll.

heylookalive’s picture

heylookalive commented

Bump, for commit please!

levelos’s picture

levelos commented
Issue summary: View changes
Status: Needs review » Fixed

Fixed! Thanks everyone, nice work. Sorry this took so long. Ref. f5c2531.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

  • Commit f5c2531 on 7.x-1.x, redhen-donation authored by micnap, committed by levelos: 
    #1930122 by Pete B and micnap: Add Views controller classes for notes...

  • Commit f5c2531 on 7.x-1.x, redhen-donation, relation-roles authored by micnap, committed by levelos: 
    #1930122 by Pete B and micnap: Add Views controller classes for notes...