It's helpful to know when the order of the view has been changed. That said, it would be nice to make the setting optional. That way site users don't have to see this message every time the order changes:
"Order of this view has been changed."

Let me know if you have any questions.
Thanks,
Mike

CommentFileSizeAuthor
#2 hide_warning_table-1929842-2.patch3.45 KBnielsonm
#1 hide_warning_table-1929842-1.patch3.44 KBnielsonm

Comments

nielsonm’s picture

nielsonm commented
StatusFileSize
new hide_warning_table-1929842-1.patch3.44 KB

Created a patch.

nielsonm’s picture

nielsonm commented
StatusFileSize
new hide_warning_table-1929842-2.patch3.45 KB

Oops, forgot to add settings to Drupal object check.

nielsonm’s picture

nielsonm commented
Status: Active » Needs review
jfrederick’s picture

jfrederick commented

This is a great start, but needs some work.

The patch currently only hides the status message in 1 out of the 4 needed scenarios. The new conditional in the patch for draggableviews_table.js:

if (!Drupal.settings.draggableviews.hideWarning)

is currently included for when draggableviews is used on a table with ajax. It should probably also take effect when the view does not use ajax.

Additionally, it should be included in draggableviews_list.js, for when the view is shown as a list rather than a table. Again, for both when it uses ajax and does not. For a total of four places.

Also, the patch needs to be re-rolled against the latest dev branch, because it does not currently apply cleanly.

These things aside, it helped me out a lot.

jfrederick’s picture

jfrederick commented
Status: Needs review » Needs work