There are two test modules for file, one appears in the Testing fieldset on the modules page and the other does not. This teeny tiny patch moves the file_module_test module into the testing fieldset with all its friends :)

CommentFileSizeAuthor
#13 core-testing_fieldset-1928752-13.patch520 bytesmtift
#10 core-testing_fieldset-1928752-10.patch452 bytesmtift
#6 core-testing_fieldset-1928752-6.patch438 bytesmtift
#5 core-testing_fieldset-1928752-5.patch439 bytesmtift
core-testing_fieldset.patch425 bytesjenlampton
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
CreditAttribution: larowlan commented
Status: Needs review » Reviewed & tested by the community

I'm curious as to how you see these on the module page, but the change is straight forward.

catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch commented
Status: Reviewed & tested by the community » Needs review

I'm confused how they end up there as well. Is there another bug or are you doing something special to show hidden modules?

cgalli’s picture

cgalli CreditAttribution: cgalli commented

Patch does not apply anymore as the file name and structure have changed.

amateescu’s picture

amateescu CreditAttribution: amateescu commented
Status: Needs review » Needs work

The patch needs to be updated for the .info -> .info.yml change: #1793074: Convert .info files to YAML

mtift’s picture

mtift
he/him
Primary language English
Location Minnesota, USA
CreditAttribution: mtift commented
Assigned: Unassigned » mtift
Status: Needs work » Needs review
FileSize
core-testing_fieldset-1928752-5.patch439 bytes

Updated patch attached

mtift’s picture

mtift
he/him
Primary language English
Location Minnesota, USA
CreditAttribution: mtift commented
FileSize
core-testing_fieldset-1928752-6.patch438 bytes

Oops. Removed the space after "Testing"

mtift’s picture

mtift
he/him
Primary language English
Location Minnesota, USA
CreditAttribution: mtift commented

Re-test

mtift’s picture

mtift
he/him
Primary language English
Location Minnesota, USA
CreditAttribution: mtift commented
Issue tags: -Novice

#6: core-testing_fieldset-1928752-6.patch queued for re-testing.

Status: Needs review » Needs work
Issue tags: +Novice

The last submitted patch, core-testing_fieldset-1928752-6.patch, failed testing.

mtift’s picture

mtift
he/him
Primary language English
Location Minnesota, USA
CreditAttribution: mtift commented
Status: Needs work » Needs review
FileSize
core-testing_fieldset-1928752-10.patch452 bytes

Not sure why this didn't work before

The last submitted patch, core-testing_fieldset-1928752-10.patch, failed testing.

mtift’s picture

mtift
he/him
Primary language English
Location Minnesota, USA
CreditAttribution: mtift commented
Status: Needs work » Needs review

#10: core-testing_fieldset-1928752-10.patch queued for re-testing.

mtift’s picture

mtift
he/him
Primary language English
Location Minnesota, USA
CreditAttribution: mtift commented
Assigned: mtift » Unassigned
Issue summary: View changes
FileSize
core-testing_fieldset-1928752-13.patch520 bytes

Just a reroll

ellishettinga’s picture

ellishettinga CreditAttribution: ellishettinga commented

The patch mentioned in #13 applies allright but can you give hints on how to view the change, because a 'testing' fieldset is not present in core (anymore?).

dermario’s picture

dermario
Primary language German
Location Zürich
CreditAttribution: dermario commented
Assigned: Unassigned » dermario
dermario’s picture

dermario
Primary language German
Location Zürich
CreditAttribution: dermario commented
Status: Needs review » Reviewed & tested by the community

I applied that patch and could verify that it is working. Please note: that patch applies to a hidden module, so it will not appear on the module-page anyway. I removed the hidden state for that module on my local machine to verify that module is present in Testing Tab. Therefore this patch is working.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott commented
Status: Reviewed & tested by the community » Fixed

Committed 9cf1a39 and pushed to 8.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.