Closed (fixed)
Project:
Menu Attach Block
Version:
7.x-1.x-dev
Component:
User interface
Priority:
Major
Category:
Feature request
Assigned:
Unassigned
Reporter:
Created:
26 Feb 2013 at 10:20 UTC
Updated:
4 Jan 2014 at 02:58 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
inders commentedAdding patch for above mentioned functionality. Tested on local instance.
@cam8001 , ccan you please review and test it?
Comment #2
cameron tod commentedThanks for the patch! Will review :)
Comment #3
cameron tod commentedComment #5
cameron tod commentedComment #6
cameron tod commented#1: ajaxloadcontent-1927772-0.patch queued for re-testing.
Comment #7
cameron tod commentedThis a great patch, and makes a lot of sense as a feature. I've done a little bit of code cleanup so that it meets Drupal coding standards, and commited it with attribution. So, thanks!
Before it gets rolled into a release, I think we need to work out a way to have a non AJAX fallback. I think we'd need to reload the whole page with the block rendered if JS wasn't available. Then we could maybe set a session variable so on the next time the page is loaded, the block is rendered inline. I want to avoid that if we can, as it breaks caching.
Another thing that is kind of interesting is permissions - I need to refresh my understanding of that.
I will take a look when I get some time.
Comment #8
inders commentedFor JS disabled case ... What about displaying the block contents inside a Iframe..? In that case I think we can avoid the mess with $_SESSION variable an Drupal caching..?
For permission thing.. I think we already taking care of it inside "menu_attach_block_load_from_key" function..? As we are using standard module_invoke for loading the block content , the permissions should work normally.
If we are talking about permission based on menu item then I think "menu_per_role" if good module for that.?