Convert user's system_config_form() to SystemConfigFormBase

This contains #1921996: Convert system_config_form() to implement FormInterface as a base class. for now. Will reroll once that's in.

Tagging.

I'll have to ask chx if he thinks drupal_form_submit() should work with FormInterface. In the meantime, here's a fix.

Nope, that workaround should be removed, this is a bug. Postponing on #1925140: drupal_form_submit() does not accept FormInterface objects

I fixed #1925140: drupal_form_submit() does not accept FormInterface objects but its not in yet, here's the interdiff from #1, I'll post a patch when there are less dependencies.

Those other issues were committed.

This needs a reroll, use #1925738: Convert language's system_config_form() to SystemConfigFormBase as a guide

The newest patch is missing all of the changes to user_menu(), as well as deleting any of the old user_admin_settings() code.

I answer @Crell's question with another question: Where does anything ever leave that context? I see config_import(), config_install_default_config(), user_mail() (what?!), and no where else but tests.

There's an issue for that. I'll find it and post it here when I'm at my computer

#1945326: Rename \Drupal\system\Tests\System\SystemConfigFormBase to \Drupal\system\Tests\System\SystemConfigFormTestBase

And I think the method is named submitForm()

+++ b/core/modules/user/lib/Drupal/user/AccountSettingsForm.phpundefined
@@ -0,0 +1,450 @@
+    $this->configFactory = $config_factory;
+    $this->configFactory->enterContext($context);

I think this should call parent::__construct($config_factory, $context) instead.

I'm guessing that's the only real change (other than create() which is fine). Interdiffs++ ;)

+++ b/core/modules/system/lib/Drupal/system/Tests/Form/FormObjectTest.phpundefined
@@ -33,7 +33,7 @@ public static function getInfo() {
     parent::setUp();
 
-    $this->form_id = new FormTestObject();
+    $this->form = new FormTestObject();
     $this->values = array(
       'bananas' => array(
         '#value' => $this->randomString(10),
diff --git a/core/modules/system/lib/Drupal/system/Tests/System/SystemConfigFormTestBase.php b/core/modules/system/lib/Drupal/system/Tests/System/SystemConfigFormTestBase.php

diff --git a/core/modules/system/lib/Drupal/system/Tests/System/SystemConfigFormTestBase.php b/core/modules/system/lib/Drupal/system/Tests/System/SystemConfigFormTestBase.php
index 69543aa..5686e3f 100644

index 69543aa..5686e3f 100644
--- a/core/modules/system/lib/Drupal/system/Tests/System/SystemConfigFormTestBase.php

--- a/core/modules/system/lib/Drupal/system/Tests/System/SystemConfigFormTestBase.php
+++ b/core/modules/system/lib/Drupal/system/Tests/System/SystemConfigFormTestBase.phpundefined

+++ b/core/modules/system/lib/Drupal/system/Tests/System/SystemConfigFormTestBase.phpundefined
+++ b/core/modules/system/lib/Drupal/system/Tests/System/SystemConfigFormTestBase.phpundefined
@@ -19,9 +19,9 @@

@@ -19,9 +19,9 @@
   /**
    * Form ID to use for testing.
    *
-   * @var string
+   * @var \Drupal\Core\Form\FormInterface.
    */
-  protected $form_id;
+  protected $form;
 
   /**
    * Values to use for testing.
@@ -45,13 +45,13 @@

@@ -45,13 +45,13 @@
   /**
    * Submit the system_config_form ensure the configuration has expected values.
    */
-  function testConfigForm() {
+  public function testConfigForm() {
     // Programmatically submit the given values.
     foreach ($this->values as $form_key => $data) {
       $values[$form_key] = $data['#value'];
     }
     $form_state = array('values' => $values);
-    drupal_form_submit($this->form_id, $form_state);
+    drupal_form_submit($this->form, $form_state);
 
     // Check that the form returns an error when expected, and vice versa.
     $errors = form_get_errors();
@@ -62,7 +62,7 @@ function testConfigForm() {

@@ -62,7 +62,7 @@ function testConfigForm() {
     );
     $this->assertTrue($valid_form, format_string('Input values: %values<br/>Validation handler errors: %errors', $args));
 
-    foreach ($this->values as $form_key => $data) {
+    foreach ($this->values as $data) {
       $this->assertEqual($data['#value'], config($data['#config_name'])->get($data['#config_key']));

I don't see how this is related to the issue.

While removing that, can you swap the __construct bit?

Oh! That explains why those hunks are in there. The user test extends SystemConfigFormTestBase, which was not using the new approach yet. My sincerest apologies.

@kim.pepper, can you reroll one last time, re-adding those test changes but keeping your constructor switch?

Thanks, that looks good now.