This is a follow up from #1884290: Implement a pluggable system for who emails get sent to

We now allow Newsletter Issue writers to choose a Recipient Handler when they send a newsletter out. This can cause an added complexity that Newsletter Issue writers do not always need to see. It would be good to allow site-builders, or the ones that set up the newsletters to choose which recipient handlers are allowed to be used with a given newsletter.

Plan:

  • Add a allowed_handlers field to the newsletter entity. Form field is of type checkboxes. We can use the RecipientHandlerManager::getOptions() function for the allowed values.
  • Add an optional parameter newsletter_id to RecipientHandlerManager::getOptions() to filter the allowed values by the field on the referenced newsletter.
CommentFileSizeAuthor
#7 simplenews.limit-handlers.1924536-interdiff-5-7.txt393 bytesadamps
#7 simplenews.limit-handlers.1924536-7.patch14.86 KBadamps
#5 simplenews.limit-handlers.1924536-5.patch14.49 KBadamps

Comments

berdir’s picture

berdir
Primary language German
Location Switzerland
commented

Exportable entities can deal with attached fields quite fine (as long as you don't have things like images and entity references are obviously tricky too).

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Issue summary: View changes

Updated with a plan

adamps’s picture

adamps commented
Version: 7.x-2.x-dev » 8.x-1.x-dev
Issue summary: View changes
Parent issue: » #3052744: [META] Problems with RecipientHandler
adamps’s picture

adamps commented
Version: 8.x-1.x-dev » 8.x-2.x-dev
Issue summary: View changes
adamps’s picture

adamps commented
Issue summary: View changes
adamps’s picture

adamps commented
Status: Active » Needs review
StatusFileSize
new simplenews.limit-handlers.1924536-5.patch14.49 KB

Status: Needs review » Needs work

The last submitted patch, 5: simplenews.limit-handlers.1924536-5.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

adamps’s picture

adamps commented
Status: Needs work » Needs review
StatusFileSize
new simplenews.limit-handlers.1924536-7.patch14.86 KB
new simplenews.limit-handlers.1924536-interdiff-5-7.txt393 bytes
adamps’s picture

adamps commented
Issue tags: +Plan to commit

  • AdamPS committed ecc884c on 8.x-2.x 
    Issue #1924536 by AdamPS: Limit what recipient handlers can be used with...
adamps’s picture

adamps commented
Status: Needs review » Fixed
Issue tags: -Plan to commit

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.