We don't use this anywhere now, it was previously used for exporting code, but we don't do that anymore either.

Patch to follow.

CommentFileSizeAuthor
#12 interdiff-1.txt737 bytesjibran
#12 interdiff.txt903 bytesjibran
#12 1922966-12.patch70.04 KBjibran
#9 1922966-8.patch69.09 KBjibran
#1 1922966.patch65.95 KBdamiankloip

Comments

damiankloip’s picture

damiankloip commented
Status: Active » Needs review
StatusFileSize
new 1922966.patch65.95 KB
dawehner’s picture

dawehner
Primary language German
commented

Maybe we should postpone that for a bit? I think it shouldn't break with to many patches.

damiankloip’s picture

damiankloip commented
Status: Needs review » Postponed

Sure, we can postpone this. Do you have any particular patches in mind that you can link here, so I know when to make it live again? :)

dawehner’s picture

dawehner
Primary language German
commented

No, not really, just wondering in general.

damiankloip’s picture

damiankloip commented

Oh, ok :) Let's just leave it as postponed for now then.

mgifford’s picture

mgifford
he/him
Primary language English
commented
Issue summary: View changes

Should this be live again now that we're at Beta1 and a year's past?

jibran’s picture

jibran
he/him
Primary language Urdu
Location Toronto, Canada
commented
Title: remove 'bool' key from option definitions » Remove 'bool' and 'translatable' key from option definitions
Assigned: damiankloip » jibran
Status: Postponed » Needs work
Issue tags: +#amsterdam2014

Working on this.

jibran’s picture

jibran
he/him
Primary language Urdu
Location Toronto, Canada
commented
Assigned: jibran » Unassigned
Status: Needs work » Needs review

Here we go.

/me stares back.

jibran’s picture

jibran
he/him
Primary language Urdu
Location Toronto, Canada
commented
StatusFileSize
new 1922966-8.patch69.09 KB

With patch this time.

stborchert’s picture

stborchert
he/him
Primary language German
commented
Status: Needs review » Reviewed & tested by the community

Tested on a clean install. Patch doesn't break anything and false positives of 'bool' => TRUE are not removed (as in vendor/phpunit or vendor/psr.

damiankloip’s picture

damiankloip commented
Status: Reviewed & tested by the community » Needs work

All looks good, just removing lots of things. You just need to remove the documentation for these keys in Drupal\views\Plugin\views\PluginBase::defineOptions too :)

jibran’s picture

jibran
he/him
Primary language Urdu
Location Toronto, Canada
commented
Status: Needs work » Needs review
StatusFileSize
new 1922966-12.patch70.04 KB
new interdiff.txt903 bytes
new interdiff-1.txt737 bytes

Thanks for the review @damiankloip and @andypost pointed that @endcode tag is missing.

damiankloip’s picture

damiankloip commented

Let's make sure it's good with the bot, this is ready to fly though.

damiankloip’s picture

damiankloip commented
Status: Needs review » Reviewed & tested by the community

RTBC

oenie’s picture

oenie commented
Issue tags: -#amsterdam2014 +Amsterdam2014

fixing the amsterdam sprint tag to amsterdam2014

sutharsan’s picture

sutharsan commented

Patch still applies.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

Committed 046bf09 and pushed to 8.0.x. Thanks!

  • alexpott committed 046bf09 on 8.0.x 
    Issue #1922966 by jibran, damiankloip: Remove 'bool' and 'translatable'...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.