When you add the page_slogan pane to a page you're specifically looking to display the site slogan. Given this pane is so simple, you wouldn't be adding it to a page if you *didn't* want the slogan displayed. As a result, it doesn't make any sense to then also check the theme settings to see if the slogan should be displayed.

CommentFileSizeAuthor
#3 ctools-n1921612.patch893 bytesDamienMcKenna
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

merlinofchaos’s picture

merlinofchaos CreditAttribution: merlinofchaos commented

I cannot fault the logic. Patch?

DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna commented
Status: Active » Needs review

This patch removes the logic that was checking the theme settings so that the block is always displayed if it's added to a page (which is what most people would expect).

DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna commented
FileSize
ctools-n1921612.patch893 bytes
merlinofchaos’s picture

merlinofchaos CreditAttribution: merlinofchaos commented
Status: Needs review » Reviewed & tested by the community

Looks reasonable to me.

DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna commented

FYI the patch also works on D6.

japerry’s picture

japerry
Location KVUO
CreditAttribution: japerry commented
Issue summary: View changes
Status: Reviewed & tested by the community » Fixed

Regression tested, fixed, and committed:

http://drupalcode.org/project/ctools.git/commit/5d0ac370d064418111595fda...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.