The "View" and "Delete" links rendered in the results/submissions page do not point at the correct destinations. This seems to be because a "./" has sneaked into the links. Replacing this in all generated links (patch attached) corrects the error.

Looking at the patch, it also seems we have two chunks of code which are identical and need refactoring. Do you want me to have a look at this?

By the way, the "Delete" link doesn't seem to delete a given form submission. I haven't worked this one out yet.

CommentFileSizeAuthor
webform.inc.patch2.1 KBAnonymous (not verified)

Comments

townxelliot’s picture

townxelliot commented

Sorry, should have logged in before submitting this, so you knew who to blame :)

jnt’s picture

jnt commented

Mine is working with the './' appearing in the URL, and I didn't pick it up. Presumably it will only work dependent on your directory access permissions and therefore needs to be changed as you have in your patch.

The duplicated code block is correct but ugly. At some point it should be functionalized. The reason for it is that when pulling data out of the database you don't know that you have all the data for a record until the next record starts or you run into the end of the database. That second fragament packages that last record which you have been assembling but not yet closed off.

Delete is also working for me so I suspect that it has something to do with the URL construction above. Let's make it a bug report. However, I shan't be able to look at it for 12 hours or so.. So if you have some time before then.. feel free..

ullgren’s picture

ullgren commented

Patch in cvs

ullgren’s picture

ullgren commented