I just had an instance where it would be really helpful for the 'inline' option of a jump menu to be configurable. Here's a small patch that makes that possible.

Files: 
CommentFileSizeAuthor
#11 ctools-1920690-views-inline-jump-menu.patch2.93 KBjnettik
FAILED: [[SimpleTest]]: [MySQL] Drupal installation failed. View
#8 views-inline-jump-menu-config_v3.patch3.04 KBjnettik
PASSED: [[SimpleTest]]: [MySQL] 1,621 pass(es). View
#5 views-inline-jump-menu-config_v2.patch3.33 KBjnettik
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch views-inline-jump-menu-config_v2.patch. Unable to apply patch. See the log in the details link for more information. View
views-inline-jump-menu-config.patch1.49 KBjnettik
PASSED: [[SimpleTest]]: [MySQL] 1,603 pass(es). View

Comments

Status: Needs review » Needs work

The last submitted patch, views-inline-jump-menu-config.patch, failed testing.

jthorson’s picture

Bot issue. Requeued.

jnettik’s picture

Status: Needs work » Needs review

Changing status back.

dawehner’s picture

There are two integrations into jump menus: The normal style and the summary style. It would be cool if you could provide a patch for both of them.

+    $options['inline'] = array('default' => TRUE, 'bool' => TRUE);

What is the default configuration in ctools? I think we should not change existing sites, so we better set it to FALSE?

jnettik’s picture

FileSize
3.33 KB
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch views-inline-jump-menu-config_v2.patch. Unable to apply patch. See the log in the details link for more information. View

I updated the patch to include both jump menus. ctools default is true so I left that setting as is for now. Let me know if you think it should change and I update that.

Status: Needs review » Needs work

The last submitted patch, views-inline-jump-menu-config_v2.patch, failed testing.

dawehner’s picture

Your patch should be relative to the views root directory not your root of your drupal installation.

jnettik’s picture

Status: Needs work » Needs review
FileSize
3.04 KB
PASSED: [[SimpleTest]]: [MySQL] 1,621 pass(es). View

Oops, sorry about that. Here is an updated patch.

dawehner’s picture

Status: Needs review » Reviewed & tested by the community

This looks pretty good!

dawehner’s picture

Project: Views » Chaos tool suite (ctools)
Version: 7.x-3.x-dev » 8.x-1.x-dev
Component: User interface » Views Content
Status: Reviewed & tested by the community » Patch (to be ported)

Thanks for writing the patch! Committed and pushed to 7.x-3.x

Let's add this to the ctools part of it in 8.x

jnettik’s picture

Status: Patch (to be ported) » Needs review
FileSize
2.93 KB
FAILED: [[SimpleTest]]: [MySQL] Drupal installation failed. View

So I ported this over. I'm having some issues testing it as the latest pull of core gives me a 500 internal error.

Status: Needs review » Needs work

The last submitted patch, ctools-1920690-views-inline-jump-menu.patch, failed testing.

jnettik’s picture

Status: Needs work » Needs review

Status: Needs review » Needs work

The last submitted patch, ctools-1920690-views-inline-jump-menu.patch, failed testing.

DamienMcKenna’s picture

Version: 8.x-1.x-dev » 8.x-2.x-dev
Issue summary: View changes

The 8.x-1.x branch has been abandoned, 8.x-2.x is being rewritten from scratch, so I've moved this to the 8.x-2.x branch.