This is a sub-issue of #1910624: [META] Introduce and complete configuration schemas in all of core.

Problem/motivation

#1866610: Introduce Kwalify-inspired schema format for configuration introduced the idea of config schema. The changelog leads to (hopefully extensive) documentation on the format at http://drupal.org/node/1905070. While there are little cleanups planned for the format overall, the current format is a result of months of back and forths, so it should be perfectly fine to apply it more widely to core.

Proposed solution

Create a configuration schema for field module.

Schema in place

Schema not yet in place
field.settings.yml

Files: 
CommentFileSizeAuthor
#11 1919164-11.jpg27.26 KBsidharthap
#10 1919164-field-schema-10.patch481 bytessandipmkhairnar
PASSED: [[SimpleTest]]: [MySQL] 52,210 pass(es). View
#6 1919164-field-schema-6.patch480 bytessandipmkhairnar
PASSED: [[SimpleTest]]: [MySQL] 52,198 pass(es). View
#6 field-schema-form.png16.7 KBsandipmkhairnar
#5 1919164-field-schema-5.patch452 bytesVikas Negi
PASSED: [[SimpleTest]]: [MySQL] 52,208 pass(es). View
#5 1919164-diff-2-5.txt1.09 KBVikas Negi
#2 1919164-field-schema-2.patch787 bytesVikas Negi
FAILED: [[SimpleTest]]: [MySQL] 52,220 pass(es), 5 fail(s), and 0 exception(s). View
#1 1919164-field-schema.patch362 bytesvijaycs85
PASSED: [[SimpleTest]]: [MySQL] 50,634 pass(es). View

Comments

vijaycs85’s picture

Status: Active » Needs review
FileSize
362 bytes
PASSED: [[SimpleTest]]: [MySQL] 50,634 pass(es). View

Adding schema file...

Vikas Negi’s picture

FileSize
787 bytes
FAILED: [[SimpleTest]]: [MySQL] 52,220 pass(es), 5 fail(s), and 0 exception(s). View

Re-rolling with code style fixes (http://drupal.org/node/1905070#codestyle)

Status: Needs review » Needs work

The last submitted patch, 1919164-field-schema-2.patch, failed testing.

vijaycs85’s picture

+++ b/core/modules/field/config/schema/field.schema.ymlundefined
+++ b/core/modules/field/config/schema/field.schema.ymlundefined
@@ -0,0 +1,9 @@

@@ -0,0 +1,9 @@
+# Schema for configuration files of field module.

missing 'the' as per code style :(

+++ b/core/modules/menu/config/menu.settings.ymlundefined
@@ -1,3 +1,3 @@
-main_links: main
+smain_links: main
 secondary_links: account
 override_parent_selector: '0'

typo/mistake?

Vikas Negi’s picture

Status: Needs work » Needs review
FileSize
1.09 KB
452 bytes
PASSED: [[SimpleTest]]: [MySQL] 52,208 pass(es). View

Fixed changes as per the above comments.

sandipmkhairnar’s picture

FileSize
16.7 KB
480 bytes
PASSED: [[SimpleTest]]: [MySQL] 52,198 pass(es). View

Correct the label for purge batch site and update the patchschema form

vijaycs85’s picture

+++ b/core/modules/field/config/schema/field.schema.ymlundefined
+++ b/core/modules/field/config/schema/field.schema.ymlundefined
@@ -0,0 +1,9 @@
+# Schema for configuration files of the Field module

One minor issue - Comment missing a full stop(".") at the end.

Status: Needs review » Needs work
Issue tags: -Configuration system, -D8MI, -language-config, -Configuration schema

The last submitted patch, 1919164-field-schema-6.patch, failed testing.

vijaycs85’s picture

Status: Needs work » Needs review
Issue tags: +Configuration system, +D8MI, +language-config, +Configuration schema

#6: 1919164-field-schema-6.patch queued for re-testing.

sandipmkhairnar’s picture

FileSize
481 bytes
PASSED: [[SimpleTest]]: [MySQL] 52,210 pass(es). View

Thanks @vijaycs85. Update patch as per the comment

sidharthap’s picture

FileSize
27.26 KB

I tested the patch #10, It works. Attach the screen shot. Thank you @sandipmkhairnar.

image

vijaycs85’s picture

Status: Needs review » Reviewed & tested by the community

Thanks @sidharthap and @sandipmkhairnar. Looks good to go to me too.

webchick’s picture

Status: Reviewed & tested by the community » Fixed

Committed to 8.x, thanks! I'll push once testbot has caught up a bit.

Automatically closed -- issue fixed for 2 weeks with no activity.

Anonymous’s picture

Issue summary: View changes

Updated issue summary.