Add tests: Source language of tmgmt_job is always 'en' [#1917874]

How to reproduce
Just try to submit a job of translating from non-English to English.

Symptoms
I am not able to do it: I am always getting medium screen of job checkout stage, where "Source language" field is absent, see screenshot:
Source language is absent.
Please note, that "Target language" is incorrect too (I am translating from Russian to English) - but I think it is just a side effect of this issue.
Also keep in mind that source_language of tmgmt_job is always 'en', see screenshot:
Source language is always en.

Diagnosis
As I see it, we have an incorrect job saving mehanism, which puts 'en' as a source language for all jobs - that is the crux.

Comment	File	Size	Author
#1	tmgmt-fixed_source_language_for_non-english-1917874-1.patch	759 bytes	PatchRanger
	tmgmt_source_language_is_always_en.png	16.77 KB	PatchRanger
	tmgmt_absent_source_language.png	34.54 KB	PatchRanger

Comments

Comment #0.0

PatchRanger commented 15 February 2013 at 05:44

Issue summary:

View changes

Image tuning.

Comment #1

PatchRanger commented 15 February 2013 at 06:15

Status:

Active

» Needs review

Status	File	Size
new	tmgmt-fixed_source_language_for_non-english-1917874-1.patch	759 bytes

Fixed. The problem is in incorrect call to entity_language. There is no more such kind of typo in TMGMT - so the patch changes only one line. Please review.

Comment #2

blueminds commented 15 February 2013 at 07:40

Status:

Needs review

» Reviewed & tested by the community

The fix is reasonable.

Comment #3

miro_dietiker

Switzerland

commented 15 February 2013 at 07:43

Status:

Reviewed & tested by the community

» Fixed

Committed, pushed, attributed.

Comment #4

PatchRanger commented 15 February 2013 at 08:01

Wow, lightning speed!)) Thanks.

Comment #5

berdir

German

Switzerland

commented 15 February 2013 at 11:10

Title:	Source language of tmgmt_job is always 'en'	» Add tests: Source language of tmgmt_job is always 'en'
Category:	bug	» task
Status:	Fixed	» Active
Issue tags:		+Needs tests

Re-opening to add test coverage. This is the fix for the fix for the fix, we need test coverage to make sure we extract the source language correctly.