For the sake of easier management of the module and for devs to only have one section to need to work in when adding new functionality it would be quite nice if the core masonry logic (calculating values and adding JS/CSS) was centralised in the core module instead of duplicated in each of the submodules.

Patch in comment #1 does exactly that.

CommentFileSizeAuthor
#6 centralized_logic-1917756-6.patch12.37 KBdeciphered
#6 interdiff.txt1.04 KBdeciphered
#1 centralized_logic-1917756-1.patch12.34 KBdeciphered

Comments

deciphered’s picture

deciphered
Primary language English
Location Ballarat, Victoria, Australia
commented
Status: Active » Needs review
StatusFileSize
new centralized_logic-1917756-1.patch12.34 KB
deciphered’s picture

deciphered
Primary language English
Location Ballarat, Victoria, Australia
commented

Bump

Anonymous’s picture

Anonymous (not verified) commented
Version: 7.x-1.x-dev » 7.x-2.x-dev
Category: task » feature

Totally agree. Going to implement this in new version of Masonry (see 7.x-2.x-dev).

deciphered’s picture

deciphered
Primary language English
Location Ballarat, Victoria, Australia
commented

Oh hey, didn't realize there was a 2.x branch already up, will have to take a peak at it at some stage soon.

Anonymous’s picture

Anonymous (not verified) commented

Take your time, nowhere near ready yet ;)
Still got a lot of changes in my local repo. that I'm yet to push...

deciphered’s picture

deciphered
Primary language English
Location Ballarat, Victoria, Australia
commented
StatusFileSize
new interdiff.txt1.04 KB
new centralized_logic-1917756-6.patch12.37 KB

Fix minor issue; Boolean FALSE not being output in JS, needs to be converted to Integar.

Anonymous’s picture

Anonymous (not verified) commented

@Deciphered: See #1942824: Typecast booleans as int for greater JS compatibility (patch included)

deciphered’s picture

deciphered
Primary language English
Location Ballarat, Victoria, Australia
commented

Yeah, figured there might be a another fix for it. This updated patch is still required as it's just porting that fix into the centralised logic issue.

Anonymous’s picture

Anonymous (not verified) commented
Status: Needs review » Fixed

Similar code has been added to 2.x-dev: http://drupalcode.org/project/masonry.git/commit/4e6e87a

You should be able to try it out, along with Masonry Fields, but Views integration is still in progress and the main API may change/be added to as that happens.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.